[16.0][FIX] document_page_tag: Use api.model_create_multi #491
Conversation
anusriNPS
force-pushed
the
16.0-document-tag-warn
branch
from
64a8591 to
4f09857
Compare
anusriNPS
force-pushed
the
16.0-document-tag-warn
branch
2 times, most recently
from
d83332f to
6abb713
Compare
| @api.model_create_multi | ||
| def create(self, vals_list): | ||
| """Be nice when trying to create duplicates""" | ||
| existing = self.search([("name", "=ilike", vals["name"])], limit=1) | ||
| if existing: | ||
| return existing | ||
| return super().create(vals) | ||
| for vals in vals_list: | ||
| existing = self.search([("name", "=ilike", vals["name"])], limit=1) | ||
| if existing: | ||
| return existing | ||
| return super().create(vals_list) |
There was a problem hiding this comment.
Issue: When trying to create two tags at the same time, one that exists and one that doesn't, we return the one tag that does exist and don't create the one that doesn't.
There was a problem hiding this comment.
Changes included to handle tag creation with one exist and not exist at the same time
anusriNPS
force-pushed
the
16.0-document-tag-warn
branch
from
6abb713 to
e6c793d
Compare
anusriNPS
force-pushed
the
16.0-document-tag-warn
branch
from
e6c793d to
8a82c39
Compare
|
watch out for the pre-commit error at line 68 in |
Using decorator api.model_create_multi for create method in document_page_tag model
anusriNPS
force-pushed
the
16.0-document-tag-warn
branch
from
8a82c39 to
9d749c8
Compare
|
This PR has the |
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 6bece12. Thanks a lot for contributing to OCA. ❤️ |
Using decorator api.model_create_multi for create method in document_page_tag model in order to avoid below warning:
WARNING devel odoo.api.create: The model odoo.addons.document_page_tag.models.document_page_tag is not overriding the create method in batch