[10.0][FIX] Split account move generated for SEPA direct debits per sequence_type #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_type is now working again The sequence_type of mandates switches from First to Recurring: - BEFORE: when state switched from 'open' to 'generated' - NOW: when state switches from 'generated' to 'uploaded'
sylvainc
approved these changes
Apr 6, 2018
|
Please change module version number |
bealdav
approved these changes
Apr 6, 2018
rafaelbn
approved these changes
Apr 7, 2018
pedrobaeza
pushed a commit
that referenced
this pull request
Apr 9, 2018
…equence_type (#464) The sequence_type of mandates switches from First to Recurring: - BEFORE: when state switched from 'open' to 'generated' - NOW: when state switches from 'generated' to 'uploaded'
|
Cherry-pick for v11 in 37d58d6 |
sergio-teruel
pushed a commit
to Tecnativa/bank-payment
that referenced
this pull request
Nov 9, 2018
…equence_type (OCA#464) The sequence_type of mandates switches from First to Recurring: - BEFORE: when state switched from 'open' to 'generated' - NOW: when state switches from 'generated' to 'uploaded'
pedrobaeza
pushed a commit
to Tecnativa/bank-payment
that referenced
this pull request
Dec 14, 2018
…equence_type (OCA#464) The sequence_type of mandates switches from First to Recurring: - BEFORE: when state switched from 'open' to 'generated' - NOW: when state switches from 'generated' to 'uploaded'
misern2
pushed a commit
to QubiQ/bank-payment
that referenced
this pull request
Mar 6, 2020
…equence_type (OCA#464) The sequence_type of mandates switches from First to Recurring: - BEFORE: when state switched from 'open' to 'generated' - NOW: when state switches from 'generated' to 'uploaded'
misern2
pushed a commit
to QubiQ/bank-payment
that referenced
this pull request
Mar 6, 2020
…equence_type (OCA#464) The sequence_type of mandates switches from First to Recurring: - BEFORE: when state switched from 'open' to 'generated' - NOW: when state switches from 'generated' to 'uploaded'
misern2
pushed a commit
to QubiQ/bank-payment
that referenced
this pull request
Mar 18, 2020
…equence_type (OCA#464) The sequence_type of mandates switches from First to Recurring: - BEFORE: when state switched from 'open' to 'generated' - NOW: when state switches from 'generated' to 'uploaded'
misern2
pushed a commit
to QubiQ/bank-payment
that referenced
this pull request
Mar 27, 2020
…equence_type (OCA#464) The sequence_type of mandates switches from First to Recurring: - BEFORE: when state switched from 'open' to 'generated' - NOW: when state switches from 'generated' to 'uploaded'
misern2
pushed a commit
to QubiQ/bank-payment
that referenced
this pull request
Apr 24, 2020
…equence_type (OCA#464) The sequence_type of mandates switches from First to Recurring: - BEFORE: when state switched from 'open' to 'generated' - NOW: when state switches from 'generated' to 'uploaded'
alexis-via
pushed a commit
to akretion/banking
that referenced
this pull request
Dec 26, 2020
…equence_type (OCA#464) The sequence_type of mandates switches from First to Recurring: - BEFORE: when state switched from 'open' to 'generated' - NOW: when state switches from 'generated' to 'uploaded'
CarlosRoca13
pushed a commit
to Tecnativa/bank-payment
that referenced
this pull request
Jan 14, 2021
…equence_type (OCA#464) The sequence_type of mandates switches from First to Recurring: - BEFORE: when state switched from 'open' to 'generated' - NOW: when state switches from 'generated' to 'uploaded'
alexis-via
pushed a commit
to akretion/banking
that referenced
this pull request
Jan 7, 2022
…equence_type (OCA#464) The sequence_type of mandates switches from First to Recurring: - BEFORE: when state switched from 'open' to 'generated' - NOW: when state switches from 'generated' to 'uploaded'
manuelregidor
pushed a commit
to sygel-technology/bank-payment
that referenced
this pull request
Apr 8, 2022
…equence_type (OCA#464) The sequence_type of mandates switches from First to Recurring: - BEFORE: when state switched from 'open' to 'generated' - NOW: when state switches from 'generated' to 'uploaded'
wpichler
pushed a commit
to wpichler/bank-payment
that referenced
this pull request
Oct 25, 2022
…equence_type (OCA#464) The sequence_type of mandates switches from First to Recurring: - BEFORE: when state switched from 'open' to 'generated' - NOW: when state switches from 'generated' to 'uploaded'
gfcapalbo
pushed a commit
to gfcapalbo/bank-payment
that referenced
this pull request
Jan 13, 2023
…equence_type (OCA#464) The sequence_type of mandates switches from First to Recurring: - BEFORE: when state switched from 'open' to 'generated' - NOW: when state switches from 'generated' to 'uploaded'
gfcapalbo
pushed a commit
to gfcapalbo/bank-payment
that referenced
this pull request
Jan 17, 2023
…equence_type (OCA#464) The sequence_type of mandates switches from First to Recurring: - BEFORE: when state switched from 'open' to 'generated' - NOW: when state switches from 'generated' to 'uploaded'
gfcapalbo
pushed a commit
to gfcapalbo/bank-payment
that referenced
this pull request
Jan 17, 2023
…equence_type (OCA#464) The sequence_type of mandates switches from First to Recurring: - BEFORE: when state switched from 'open' to 'generated' - NOW: when state switches from 'generated' to 'uploaded'
wpichler
pushed a commit
to wpichler/bank-payment
that referenced
this pull request
Jan 27, 2023
…equence_type (OCA#464) The sequence_type of mandates switches from First to Recurring: - BEFORE: when state switched from 'open' to 'generated' - NOW: when state switches from 'generated' to 'uploaded'
Reyes4711-S73
pushed a commit
to Studio73/bank-payment
that referenced
this pull request
Feb 8, 2023
…equence_type (OCA#464) The sequence_type of mandates switches from First to Recurring: - BEFORE: when state switched from 'open' to 'generated' - NOW: when state switches from 'generated' to 'uploaded'
Reyes4711-S73
pushed a commit
to Studio73/bank-payment
that referenced
this pull request
Mar 13, 2023
…equence_type (OCA#464) The sequence_type of mandates switches from First to Recurring: - BEFORE: when state switched from 'open' to 'generated' - NOW: when state switches from 'generated' to 'uploaded'
Reyes4711-S73
pushed a commit
to Studio73/bank-payment
that referenced
this pull request
Mar 13, 2023
…equence_type (OCA#464) The sequence_type of mandates switches from First to Recurring: - BEFORE: when state switched from 'open' to 'generated' - NOW: when state switches from 'generated' to 'uploaded'
Reyes4711-S73
pushed a commit
to Studio73/bank-payment
that referenced
this pull request
Mar 21, 2023
…equence_type (OCA#464) The sequence_type of mandates switches from First to Recurring: - BEFORE: when state switched from 'open' to 'generated' - NOW: when state switches from 'generated' to 'uploaded'
Reyes4711-S73
pushed a commit
to Studio73/bank-payment
that referenced
this pull request
Mar 21, 2023
…equence_type (OCA#464) The sequence_type of mandates switches from First to Recurring: - BEFORE: when state switched from 'open' to 'generated' - NOW: when state switches from 'generated' to 'uploaded'
Reyes4711-S73
pushed a commit
to Studio73/bank-payment
that referenced
this pull request
Apr 5, 2023
…equence_type (OCA#464) The sequence_type of mandates switches from First to Recurring: - BEFORE: when state switched from 'open' to 'generated' - NOW: when state switches from 'generated' to 'uploaded'
Reyes4711-S73
pushed a commit
to Studio73/bank-payment
that referenced
this pull request
May 4, 2023
…equence_type (OCA#464) The sequence_type of mandates switches from First to Recurring: - BEFORE: when state switched from 'open' to 'generated' - NOW: when state switches from 'generated' to 'uploaded'
Reyes4711-S73
pushed a commit
to Studio73/bank-payment
that referenced
this pull request
May 29, 2023
…equence_type (OCA#464) The sequence_type of mandates switches from First to Recurring: - BEFORE: when state switched from 'open' to 'generated' - NOW: when state switches from 'generated' to 'uploaded'
JasminSForgeFlow
pushed a commit
to ForgeFlow/bank-payment
that referenced
this pull request
Mar 18, 2024
…equence_type (OCA#464) The sequence_type of mandates switches from First to Recurring: - BEFORE: when state switched from 'open' to 'generated' - NOW: when state switches from 'generated' to 'uploaded'
JasminSForgeFlow
pushed a commit
to ForgeFlow/bank-payment
that referenced
this pull request
Apr 3, 2024
…equence_type (OCA#464) The sequence_type of mandates switches from First to Recurring: - BEFORE: when state switched from 'open' to 'generated' - NOW: when state switches from 'generated' to 'uploaded'
alexis-via
pushed a commit
to akretion/banking
that referenced
this pull request
Jan 28, 2025
…equence_type (OCA#464) The sequence_type of mandates switches from First to Recurring: - BEFORE: when state switched from 'open' to 'generated' - NOW: when state switches from 'generated' to 'uploaded'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v8, the account move generated for SEPA direct debit was split per sequence type.
With the current code, it was not working any more because the mandates were switched from 'first' to 'recurring' upon generation of the payment file, but the move was generated later when the debit order is marked as uploaded (so, at that step, all mandates were seen as recurring).
With this PR, the mandates are switched from first to recurring AFTER generation of the account move. So the split of the account move per sequence_type is working again. And it's much better to do it at that step because, if you cancel the debit order when it is at the "generated" step, you will keep your mandates unchanged, which is a good thing.