[11.0][MIG] account credit control dunning fees #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# The first commit's message is: [ADD] credit control dunning fees module # This is the 2nd commit message: [ADD] docstring # This is the 3rd commit message: [FIX] FeesComputer model specification to act as a abstract class without needing overriding # This is the 4th commit message: [IMP] fees column in report and mail # This is the 5th commit message: [FIX] dunning fees computer to register itself # This is the 6th commit message: [RM] unused import # This is the 7th commit message: [PEP8] # This is the 8th commit message: [IMP] module documentation # This is the 9th commit message: [ADD] dunniing fees translations # This is the 10th commit message: [FIX] name of level in tests # This is the 11th commit message: [TYPOS] # This is the 12th commit message: Set all addons to uninstallable
[ADD] docstring [FIX] FeesComputer model specification to act as a abstract class without needing overriding [IMP] fees column in report and mail [FIX] dunning fees computer to register itself [RM] unused import [PEP8] [IMP] module documentation [ADD] dunniing fees translations [FIX] name of level in tests [TYPOS] Set all addons to uninstallable [ADD] credit control dunning fees module [ADD] docstring [FIX] FeesComputer model specification to act as a abstract class without needing overriding [IMP] fees column in report and mail [FIX] dunning fees computer to register itself [RM] unused import [PEP8] [IMP] module documentation [ADD] dunniing fees translations [FIX] name of level in tests [TYPOS] Set all addons to uninstallable Rename all addons to xxx_unported to be travis compliant
[ADD] docstring [FIX] FeesComputer model specification to act as a abstract class without needing overriding [IMP] fees column in report and mail [FIX] dunning fees computer to register itself [RM] unused import [PEP8] [IMP] module documentation [ADD] dunniing fees translations [FIX] name of level in tests [TYPOS] Set all addons to uninstallable [ADD] credit control dunning fees module [ADD] docstring [FIX] FeesComputer model specification to act as a abstract class without needing overriding [IMP] fees column in report and mail [FIX] dunning fees computer to register itself [RM] unused import [PEP8] [IMP] module documentation [ADD] dunniing fees translations [FIX] name of level in tests [TYPOS] Set all addons to uninstallable Rename all addons to xxx_unported to be travis compliant [ADD] credit control dunning fees module [ADD] docstring [FIX] FeesComputer model specification to act as a abstract class without needing overriding [IMP] fees column in report and mail [FIX] dunning fees computer to register itself [RM] unused import [PEP8] [IMP] module documentation [ADD] dunniing fees translations [FIX] name of level in tests [TYPOS] Set all addons to uninstallable Rename all addons to xxx_unported to be travis compliant Revert "Rename all addons to xxx_unported to be travis compliant" This reverts commit 7eb1827. [ADD] credit control dunning fees module [ADD] docstring [FIX] FeesComputer model specification to act as a abstract class without needing overriding [IMP] fees column in report and mail [FIX] dunning fees computer to register itself [RM] unused import [PEP8] [IMP] module documentation [ADD] dunniing fees translations [FIX] name of level in tests [TYPOS] Set all addons to uninstallable Rename all addons to xxx_unported to be travis compliant Revert "Rename all addons to xxx_unported to be travis compliant" This reverts commit 7eb1827. [FIX] move all unported addons into __unported__ folder instead of adding _unported suffix [FIX] flake8 PEP8 for module account_credit_control_dunning_fees [FIX] flake8 PEP8 for module account_credit_control_dunning_fees [FIX] pep8 line length to 80, activate pep8 check in travis, and add noqa on scenario while waiting improvement of quality-tools Add missing security on `credit.control.dunning.fees.computer`
Set account_credit_control_dunning_fees to installable Extract the module description to README.rst Port Dunning fees to the new API, activate the tests for 8.0 Add fees in the report Use the new API instead of mocks for FixedFeesTester It will be easier to write additional tests Remove required on the currency and fallback to company's currency... ... on the policy level if it is empty. Also, it fixes a bug when a credit line had no currency and the level had the company's currency. As False is different than any currency, it entered in res_currency.compute() with a False currency. It must just fallback on the company's currency if the credit line's currency is empty.
With that, the suite is run even when we update another module and that not what we expect. Remove the unused mako template Include the fees in the open amount Display the fees column before the open amount, it is more logical since it is invoice amount + fees amount. Update translation of account_credit_control_dunning_fees Update translations, translate words of the report in German
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
OCA Transbot updated translations from Transifex
simahawk
requested changes
Feb 19, 2018
|
|
||
| The product is used to compute taxes in reconciliation process. | ||
|
|
||
| .. figure:: path/to/local/image.png |
| <field name="arch" type="xml"> | ||
| <xpath expr="//notebook//notebook/page[//field[@name='email_template_id']]" position="after"> | ||
| <page string="Fees"> | ||
| <group> |
There was a problem hiding this comment.
Do you need both groups? If yes, name at least the outer one.
|
tests are failing because of missing dep from the other PR: add separated commit to drop later before merge w/ oca_depencies.txt pointing to that PR's branch. |
grindtildeath
force-pushed
the
11.0-mig-account_credit_control_dunning_fees
branch
from
14aeee1 to
f9b4def
Compare
simahawk
approved these changes
Feb 26, 2018
ghost
approved these changes
Mar 1, 2018
| Installation | ||
| ============ | ||
|
|
||
| Just install it. |
guewen
approved these changes
Mar 5, 2018
|
functional tests are Ok - good job ! |
|
@grindtildeath @yvaucher #603 merged, can we close this too? |
|
@simahawk For me, migration is done, and this PR can be merged. |
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on :