10.0 Port account_fiscal_position_vat_check #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmignon
suggested changes
Oct 11, 2016
|
|
||
| { | ||
| 'name': 'Account Fiscal Position VAT Check', | ||
| 'version': '8.0.0.1.1', | ||
| 'version': '10.0.0.1.1', |
pedrobaeza
requested changes
Oct 11, 2016
|
|
||
| @api.multi | ||
| def action_move_create(self): | ||
| '''Check that the customer has VAT set |
There was a problem hiding this comment.
Docstrings uses triple double-quote
|
|
||
| @api.onchange('property_account_position_id') | ||
| def fiscal_position_change(self): | ||
| '''Warning if the fiscal position requires a VAT number and the |
| '''Warning if the fiscal position requires a VAT number and the | ||
| partner doesn't have one yet''' | ||
| fp = self.property_account_position_id | ||
| if fp and self.customer and not self.vat: |
There was a problem hiding this comment.
You can save one if putting directly if fp.vat_required in the first condition
- better version number to start - triple quotes on docstrings - remove one if
pedrobaeza
reviewed
Oct 11, 2016
| "that require the customer to have a VAT number, " | ||
| "but the VAT number is missing.") % fp.name | ||
| } | ||
| if fp and fp.vat_required and self.customer and not self.vat: |
There was a problem hiding this comment.
You don't need to check fp, as fp.vat_required will be False if fp is an empty recordset, but not blocking.
pedrobaeza
approved these changes
Oct 11, 2016
carlos-domatix
pushed a commit
to Domatix/account-financial-tools
that referenced
this pull request
Nov 14, 2017
[MIG] account_fiscal_position_vat_check: to v10
rven
pushed a commit
to rven/account-financial-tools
that referenced
this pull request
Mar 1, 2018
[MIG] account_fiscal_position_vat_check: to v10
rven
pushed a commit
to rven/account-financial-tools
that referenced
this pull request
Aug 17, 2018
[MIG] account_fiscal_position_vat_check: to v10
rven
pushed a commit
to rven/account-financial-tools
that referenced
this pull request
Aug 17, 2018
[MIG] account_fiscal_position_vat_check: to v10
rven
pushed a commit
to rven/account-financial-tools
that referenced
this pull request
Aug 17, 2018
[MIG] account_fiscal_position_vat_check: to v10
alexis-via
pushed a commit
to akretion/account-financial-tools
that referenced
this pull request
Jan 31, 2019
[MIG] account_fiscal_position_vat_check: to v10
Tardo
pushed a commit
to Tecnativa/account-financial-tools
that referenced
this pull request
Jun 13, 2019
[MIG] account_fiscal_position_vat_check: to v10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.