Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

16.0 mig account_template_active #1491

Merged
merged 8 commits into from
Jan 19, 2023
Merged

16.0 mig account_template_active #1491

merged 8 commits into from
Jan 19, 2023

Conversation

legalsylvain
Copy link
Contributor

quite simple migration

- use new web_ribbon widget to display archived items on form views
- change inheritance from account to account_usability regarding views that disappeared in V16

@rafaelbn
Copy link
Member

/ocabot migration account_template_active

@legalsylvain could you please rebase?

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Dec 23, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 23, 2022
Open
33 tasks
@rafaelbn
Copy link
Member

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 16.0.

@OCA-git-bot OCA-git-bot force-pushed the 16.0-mig-account_template_active branch from 7e53db9 to 05c5a21 Compare December 23, 2022 13:18
@legalsylvain legalsylvain force-pushed the 16.0-mig-account_template_active branch from 05c5a21 to 273d095 Compare January 3, 2023 11:32
@legalsylvain
Copy link
Contributor Author

@StefanRijnhart, @jcdrubay : could you take a look on this trivial PR ?
thanks !

rafaelbn
rafaelbn approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in runboat 👍

account_template_active/README.rst
Usage
=====

* Go to Configuration > Templates
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Go to Accounting -> Configuración -> Templates

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in readme/USAGE.rst. (the mentioned file is autogenerated)

@rafaelbn rafaelbn changed the title 16.0 mig account template active 16.0 mig account_template_active Jan 4, 2023
StefanRijnhart
StefanRijnhart approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please fix adding the top Accounting menu in the readme as Raphael suggests.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@legalsylvain legalsylvain force-pushed the 16.0-mig-account_template_active branch from 273d095 to da41624 Compare January 19, 2023 16:24
@legalsylvain
Copy link
Contributor Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Sorry @legalsylvain you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@legalsylvain
Copy link
Contributor Author

OCA/oca-github-bot#226 is definitively annoying.

rafaelbn
rafaelbn approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1491-by-rafaelbn-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 771f276 into OCA:16.0 Jan 19, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f323437. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@legalsylvain @rafaelbn @OCA-git-bot @StefanRijnhart @oca-travis