[15.0][MIG] analytic_tag_dimension: Migration to 15.0 #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesar-tecnativa
force-pushed
the
15.0-mig-analytic_tag_dimension
branch
4 times, most recently
from
ec08934 to
8aacc3c
Compare
|
@pedrobaeza could you please review this? |
|
@chienandalu could you review this? |
chienandalu
reviewed
Jul 1, 2022
chienandalu
reviewed
Jul 1, 2022
There was a problem hiding this comment.
Ok, as for the module review @carlosdauden could be more suitable than me
|
@carlosdauden you you please review it? |
cesar-tecnativa
changed the title
|
@CarlosRoca13 could you please review this? |
CarlosRoca13
approved these changes
Jul 6, 2022
|
@LudLaf Please review |
pedrobaeza
requested changes
Jul 11, 2022
Issue with a couple of empty lines (one to be added, another to be removed) is now sorted. There's another change still pending in |
cesar-tecnativa
force-pushed
the
15.0-mig-analytic_tag_dimension
branch
from
225a529 to
0c2b57c
Compare
carlosdauden
approved these changes
Aug 4, 2022
* [REF] analytic_tag_dimension: Improve additional fields creation * [UX] analytic_tag_dimension: Warn user about spaces in codes * [FIX] analytic_tag_dimension: fix tests * [IMP] analytic_tag_dimension: make tests SavepointCase
Creating dimensions, you can face this error: psycopg2.ProgrammingError: column ail.x_dimension_xxx does not exist LINE 48: , ail.x_dimension_xxx as x_dimension_xxx, ai.team_.. This is because the column is not yet populated in the moment when the model initialization is triggered. In this commit, we inhibit the population of that field in the report on that case, and launching manual initialization later when done.
- More simplicity - Don't use demo data - Test all conditions on each model
Previous code was doing a deferred write after the creation/first write for easing the code, but it's very bad for performance in such used objects. This commits changes the way this is handled for covering the cases in advance, and thus not requiring a second write. The only drawback is that writing on multiple records means to perform a write on each record separately. This case was also happening previously, and we have gained one write (the initial one), but it's not the ideal one in terms of performance. A possible improvement can be to group the records with the same final values to be performed at once.
When you remove tags, dimensions fields were not updated accordingly before this commit.
…nstallation If not, there is remaining garbage in ir.model.fields and SQL columns in tables, avoiding a second install of the module or to reuse the same dimension code.
After all the previous works, it's fair to do it.
cesar-tecnativa
force-pushed
the
15.0-mig-analytic_tag_dimension
branch
from
06016a0 to
18bfcee
Compare
|
All changes are done. I removed unused new tests and keep compatibility with the previous version. |
pedrobaeza
approved these changes
Aug 15, 2022
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at d1b8a96. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tecnativa TT37712