Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][ADD] new module sale_stock_analytic #334

Merged
merged 2 commits into from
Aug 30, 2022
Merged

[13.0][ADD] new module sale_stock_analytic #334

merged 2 commits into from
Aug 30, 2022

Conversation

baimont
Copy link
Contributor

@baimont baimont commented Nov 10, 2020

New module that copies the analytic account of the sale order and the analytic tags of the sale order line to the stock move

Depends on #332

@baimont baimont force-pushed the bai_13.0-account-analytic-sale_stock_analytic branch from 68363a9 to 352e703 Compare November 10, 2020 12:28
@sanrav
Copy link
Contributor

sanrav commented Nov 11, 2020

Functional testing OK

sanrav
sanrav approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@sanrav sanrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional testing OK

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@baimont baimont force-pushed the bai_13.0-account-analytic-sale_stock_analytic branch from 352e703 to f5c73cb Compare November 26, 2020 12:08
MeetKD
MeetKD suggested changes Nov 27, 2020
View reviewed changes
Copy link

@MeetKD MeetKD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor Changes !

@baimont baimont force-pushed the bai_13.0-account-analytic-sale_stock_analytic branch from f5c73cb to e42f7c8 Compare January 27, 2021 14:12
@baimont baimont force-pushed the bai_13.0-account-analytic-sale_stock_analytic branch from e42f7c8 to 42f1211 Compare January 27, 2021 14:15
@rousseldenis
Copy link
Contributor

@baimont Same remarks as for purchase module #411

@celm1990-sh
Copy link

Hi, i see PR related are merge, because this PR is nor merge yet???
@baimont @rousseldenis

@rafaelbn rafaelbn added this to the 13.0 milestone Apr 7, 2022
@rafaelbn
Copy link
Member

rafaelbn commented Apr 7, 2022

Hello @baimont , this PR is pending because you have a comment of @rousseldenis here: #334 (comment) without answer. Thank you! 😄

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 14, 2022
@dreispt
Copy link
Member

dreispt commented Aug 30, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-334-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 988f646 into OCA:13.0 Aug 30, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1f96b30. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MeetKD MeetKD MeetKD requested changes

@apineux apineux apineux approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@sanrav sanrav sanrav approved these changes

@celm1990-sh celm1990-sh celm1990-sh approved these changes

Assignees
No one assigned
Labels
merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.
9 participants
@baimont @sanrav @OCA-git-bot @rousseldenis @celm1990-sh @rafaelbn @dreispt @apineux @MeetKD