Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken YAML in examples/v3.0/api-with-examples.yaml #1914

Merged
merged 2 commits into from
Apr 9, 2020

Conversation

eemeli
Copy link
Contributor

@eemeli eemeli commented May 2, 2019

YAML requires that indented flow collections are at least as indented as their starting character, and the closing brace in the example is indented by one less space character than it should be.

See also eemeli/yaml#108, arx-8/swagger-viewer#20

@perlpunk
Copy link

perlpunk commented May 2, 2019

Actually there are two more places where it needs indentation, line 127 and 167

@eemeli
Copy link
Contributor Author

eemeli commented May 3, 2019

@perlpunk You're right. I went and fixed the rest as well. In addition to the ones you mentioned, I restyled the flow collections set as values of block mappings to not start on the same line as their key, as those require the closing brace to be indented at least one space more than the mapping. With them starting on separate lines the braces line up better.

Copy link
Member

@MikeRalphson MikeRalphson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cebe
Copy link
Contributor

cebe commented Feb 20, 2020

this conflicts with/is duplicate of #2036

@darrelmiller
Copy link
Member

@eemeli Thank you for fixing this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants