Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo #1785

Merged
merged 6 commits into from
Jan 31, 2019
Merged

Fixed typo #1785

merged 6 commits into from
Jan 31, 2019

Conversation

sergej2705
Copy link
Contributor

No description provided.

@sergej2705 sergej2705 mentioned this pull request Dec 21, 2018
Closed
@MikeRalphson
Copy link
Member

Sorry, my bad, the PR needs to update versions/3.0.3.md too.

@sergej2705
Copy link
Contributor Author

already done by 7837eb4

@MikeRalphson
Copy link
Member

MikeRalphson commented Dec 21, 2018 •
edited
Loading

Thanks update to 3.0.2 should be a nop if this PR is squashed.

ioggstream
ioggstream approved these changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@ioggstream ioggstream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MikeRalphson
Copy link
Member

@sergej2705 could you remove the commits that reference 3.0.2.md completely? Patch level changes should only affect one (upcoming) release version.

@sergej2705
Copy link
Contributor Author

done

MikeRalphson
MikeRalphson approved these changes Jan 14, 2019
View reviewed changes
Copy link
Member

@MikeRalphson MikeRalphson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. PR will need to be squashed.

@webron webron merged commit 9cd19ea into OAI:v3.0.3-dev Jan 31, 2019
@sergej2705 sergej2705 deleted the v3.0.3-dev branch June 13, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeRalphson MikeRalphson MikeRalphson approved these changes

@darrelmiller darrelmiller darrelmiller approved these changes

@ioggstream ioggstream ioggstream approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sergej2705 @MikeRalphson @darrelmiller @ioggstream @webron