-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): allow psr/http-message v2 #223
Conversation
In the CI:
So that's not enough. Also, is this lib really compatible with v2? Doesn't it miss some return types? |
Hm, let's test it. |
8d096fb
to
f0aa0ba
Compare
There are indeed some type changes required but I believe the v2 support won't be possible now since old php versions are allowed. |
We should bump to PHP >=7.2 also |
If that's okay with you I've opened |
Also, I think we cannot have support for both v1 and v2 since methods with typed arguments are not backward compatible. |
because of the behavior change when passing incompatible types, or? |
Because changing e.g. - public function withProtocolVersion($version): self
+ public function withProtocolVersion(string $version): self is required and compatible with v2 but not compatible with v1 |
It's compatible with 1.1, so we could just bump to ^1.1|^2.0, no? |
Test suite is being adapted here php-http/psr7-integration-tests#68 |
Closing in favor of #234, thanks for pushing for this. |
No description provided.