Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed ManufacturingCenter gui handler bug #778

Merged
merged 1 commit into from
Feb 10, 2025
Merged

fixed ManufacturingCenter gui handler bug #778

merged 1 commit into from
Feb 10, 2025

Conversation

Keriils
Copy link
Contributor

@Keriils Keriils commented Feb 8, 2025

fix #742

@Keriils
Copy link
Contributor Author

Keriils commented Feb 8, 2025

image

@czqwq
Copy link

czqwq commented Feb 9, 2025

还得是NHU老登实在,直接出手修了

@Nxer Nxer merged commit 28847eb into Nxer:main Feb 10, 2025
1 check passed
@Taskeren
Copy link
Contributor

为什么是在这里打补丁,而不是修展示的模组
而且连个注释都没有

@Keriils
Copy link
Contributor Author

Keriils commented Feb 15, 2025

我看展示模组的意图就是获取凋落物,而不是你在结构元素中定义的方块,
如果修的话要么提供一个额外的接口用于特殊展示的方块比如ISpecialRenderBlockxxx...(比较简单的方式)或者直接从结构定义那边拿走方块但是估计和那边的意图相背离了,再者如果这样修可能导致其他问题...... 我表示还是打补丁来的方便和快捷(实力有限)
至于注释,当时没考虑到,主要就是调用了 blockrenderer6343.integration.nei.GuiMultiblockHandler#scanIngredients 获取 render world的方块 用这个补丁修复问题应该不大......

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

新加工中心多方块预览显示材料错误
4 participants