Add macOS support to build script

[alexjurkiewicz]

macOS bundles BSD readlink, which doesn't support -f (or any
equivalent). Instead, use stat (again, the BSD version) as a partial
replacement -- it will canonicalise symlinks.

You also can't strip ELF binaries on macOS, since the bundled strip only
supports Mach-O format.

[uablrek]

Thanks for your contribution.

I don't like [ in scripts. Unix shell scripts are closer to a functional language regarding conditionals and using [ (which is a built-in alias for test) encourage the imperative programming style. Note for instance that the man page doesn't mention "condition" or "expresstion" when describing if (from man bash);

       if list; then list; [ elif list; then list; ] ... [ else list; ] fi

A very common misuse (which I find very annoying) is constructs like;

  grep -q pattern some/file
  if [ $? -eq 0 ]; then
    echo "Found"
...

[alexjurkiewicz]

Ok, how would you like me to proceed?

…

On Mon, 14 Mar 2022, 17:08 Lars Ekman, ***@***.***> wrote: Thanks for your contribution. I don't like [ in scripts. Unix shell scripts are closer to a functional language regarding conditionals and using [ (which is a built-in alias for test) encourage the imperative programming style. Note for instance that the man page doesn't mention "condition" or "expresstion" when describing if (from man bash); if list; then list; [ elif list; then list; ] ... [ else list; ] fi A very common misuse (which I find very annoying) is constructs like; grep -q pattern some/file if [ $? -eq 0 ]; then echo "Found" ... — Reply to this email directly, view it on GitHub <#14 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAC4U5PGHRS66V5XNE7RIEDU73JW3ANCNFSM5QUCCHIA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[uablrek]

Make the suggested upates, squash and force-push.

[alexjurkiewicz]

Perhaps I'm not as smart as you, because I don't understand what your suggested updates are. I understand you "don't like [ in scripts", but not what approach you prefer.

[uablrek]

Please remove the [ and replace with test. Like;

if test  "$(uname)" = Darwin  ; then
	test -s "$dir" && dir=$(stat -f%Y "$0")
else
	dir=$(readlink -f "$dir")
fi

[uablrek]

Maybe better to use the safer;

if uname | grep -qi Darwin  ; then
...

This illustrates my aversion to [, one tend to forget that the "thing" after if is not an expression.

[alexjurkiewicz]

done

[uablrek]

Replace with;

test "$(uname)" != Darwin && strip image/kahttp

[uablrek]

Same as above;

uname | grep -qi darwin || strip image/kahttp

[alexjurkiewicz]

done

[uablrek]

My bad, sorry. I had started a review and made suggestions but was unaware that the suggestion was not visible to you unless I press a (somewhat hidden) "Submit" button. I hope you see them now.

[uablrek]

And my apologize again for answer in #14 (comment). I thought my suggestions were visible.

[alexjurkiewicz]

All good. Updated as requested.