New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache peers list #756

Open

mariusSincovici wants to merge 4 commits into mesh-cleanup from cache-peers-list

Contributor

mariusSincovici commented Feb 4, 2025

No description provided.

mariusSincovici temporarily deployed to Internal

February 4, 2025 08:27

— with

GitHub Actions Inactive

mariusSincovici temporarily deployed to Internal

February 4, 2025 08:31

— with

GitHub Actions Inactive

mariusSincovici temporarily deployed to Internal

February 4, 2025 19:30

— with

GitHub Actions Inactive

mariusSincovici force-pushed the cache-peers-list branch from 551b3f7 to b5e68c0 Compare

February 4, 2025 19:41

mariusSincovici temporarily deployed to Internal

February 4, 2025 19:41

— with

GitHub Actions Inactive

mariusSincovici marked this pull request as ready for review

February 4, 2025 19:42

mariusSincovici temporarily deployed to Internal

February 5, 2025 05:53

— with

GitHub Actions Inactive

keliramu reviewed

View reviewed changes

meshnet/server.go Outdated Show resolved Hide resolved

keliramu reviewed

View reviewed changes

meshnet/jobs.go Outdated Show resolved Hide resolved

keliramu reviewed

View reviewed changes

meshnet/jobs/job_refresh_meshnet_map.go Outdated Show resolved Hide resolved

keliramu reviewed

View reviewed changes

meshnet/server_test.go Outdated Show resolved Hide resolved

keliramu reviewed

View reviewed changes

meshnet/server.go Outdated Show resolved Hide resolved

keliramu reviewed

View reviewed changes

meshnet/server.go Outdated Show resolved Hide resolved

keliramu reviewed

View reviewed changes

meshnet/server.go Outdated Show resolved Hide resolved

keliramu reviewed

View reviewed changes

meshnet/server.go Outdated Show resolved Hide resolved

keliramu reviewed

View reviewed changes

meshnet/server.go Outdated Show resolved Hide resolved

keliramu reviewed

View reviewed changes

meshnet/server.go Outdated Show resolved Hide resolved

keliramu reviewed

View reviewed changes

meshnet/server.go Outdated Show resolved Hide resolved

keliramu reviewed

View reviewed changes

meshnet/server.go Outdated Show resolved Hide resolved

keliramu reviewed

View reviewed changes

meshnet/server.go Outdated Show resolved Hide resolved

keliramu reviewed

View reviewed changes

meshnet/server.go Outdated Show resolved Hide resolved

keliramu reviewed

View reviewed changes

meshnet/server.go Outdated Show resolved Hide resolved

keliramu reviewed

View reviewed changes

meshnet/server.go Outdated Show resolved Hide resolved

keliramu reviewed

View reviewed changes

meshnet/server.go Outdated Show resolved Hide resolved

mariusSincovici temporarily deployed to Internal

February 5, 2025 15:07

— with

GitHub Actions Inactive

mariusSincovici temporarily deployed to Internal

February 6, 2025 08:02

— with

GitHub Actions Inactive

devzbysiu reviewed

View reviewed changes

daemon/models/cached_value.go Outdated Show resolved Hide resolved

mariusSincovici temporarily deployed to Internal

February 6, 2025 09:50

— with

GitHub Actions Inactive

mariusSincovici temporarily deployed to Internal

February 6, 2025 15:15

— with

GitHub Actions Inactive

mariusSincovici temporarily deployed to Internal

February 6, 2025 21:15

— with

GitHub Actions Inactive

Savolro temporarily deployed to Internal

February 25, 2025 13:47

— with

GitHub Actions Inactive

Savolro force-pushed the cache-peers-list branch from a32a34c to 729d935 Compare

February 25, 2025 13:57

Savolro temporarily deployed to Internal

February 25, 2025 13:57

— with

GitHub Actions Inactive

Savolro force-pushed the cache-peers-list branch from 729d935 to 8612ccd Compare

February 25, 2025 19:59

Savolro temporarily deployed to Internal

February 25, 2025 19:59

— with

GitHub Actions Inactive

Savolro marked this pull request as ready for review

February 25, 2025 20:00

Savolro force-pushed the cache-peers-list branch from 8612ccd to 139f69d Compare

February 25, 2025 20:03

Savolro temporarily deployed to Internal

February 25, 2025 20:03

— with

GitHub Actions Inactive


          Split mesh.Retriever from mesh.Registry

b8890a4

Split is done in order to allow creating separate functionality
expansions when data is retrieved from API or uploaded to API.

Signed-off-by: Savolro <me@savolro.com>

Savolro force-pushed the cache-peers-list branch from 139f69d to 81a58d8 Compare

February 26, 2025 09:24

Savolro temporarily deployed to Internal

February 26, 2025 09:24

— with

GitHub Actions Inactive

Savolro force-pushed the cache-peers-list branch from 81a58d8 to 752803e Compare

February 26, 2025 09:46

Savolro temporarily deployed to Internal

February 26, 2025 09:46

— with

GitHub Actions Inactive

Savolro force-pushed the mesh-cleanup branch from 7de6d8a to 373e8e2 Compare

February 26, 2025 09:47

Savolro force-pushed the cache-peers-list branch from 752803e to 5d878e4 Compare

February 26, 2025 10:08

Savolro temporarily deployed to Internal

February 26, 2025 10:08

— with

GitHub Actions Inactive

Savolro force-pushed the cache-peers-list branch from 5d878e4 to 859f81a Compare

February 26, 2025 10:13

Savolro temporarily deployed to Internal

February 26, 2025 10:13

— with

GitHub Actions Inactive

Savolro force-pushed the cache-peers-list branch from 859f81a to 0886404 Compare

February 26, 2025 10:40

Savolro temporarily deployed to Internal

February 26, 2025 10:40

— with

GitHub Actions Inactive

mariusSincovici commented

View reviewed changes

meshnet/mapper/notifying.go

    
              	lastMap := r.lastMap

              	peerPub := r.peerPub

              	r.mu.RUnlock()

              	if !forceUpdate && !bytes.Equal(lastMap, resp.Raw) {

Contributor Author

mariusSincovici Feb 26, 2025

I think this condition is not correct 🤔
shouldn't be if forceUpdate || !bytes.Equal(lastMap, resp.Raw) ?

Contributor

Savolro Feb 26, 2025

Updated coment with the explaination

Savolro force-pushed the cache-peers-list branch from 0886404 to 10c3318 Compare

February 26, 2025 21:38

Savolro temporarily deployed to Internal

February 26, 2025 21:38

— with

GitHub Actions Inactive

Savolro force-pushed the cache-peers-list branch from 10c3318 to 0ce7b9d Compare

February 26, 2025 22:08

Savolro temporarily deployed to Internal

February 26, 2025 22:08

— with

GitHub Actions Inactive

Savolro added 3 commits

February 27, 2025 00:16


          Introduce meshnet map caching

3ff0956

When meshnet map is requested from the `mesh.Retriever`, instead of
calling API directly, it is called via `CachingRetriever`. Also,
`NotifyingRegistry` was introduced as well to make sure that any changes
to meshnet map made by this device would notify the subscribers about
it. This also means, that application now reacts to these changes in a
same way as it does to NC messages, therefore it is no longer needed to
call networker directly from meshnet map modifying gRPC functions.

Signed-off-by: Savolro <me@savolro.com>


          Implement meshnet.NotifyingInviter

c0b82fa

When accepting meshnet invitations, it is guaranteed that new peer is
added to the meshnet. Therefore, it is valid to refresh meshnet at this
point.

Signed-off-by: Savolro <me@savolro.com>


          Remove unused meshnet functionality

330159c

Signed-off-by: Savolro <me@savolro.com>

Savolro force-pushed the cache-peers-list branch from 0ce7b9d to 330159c Compare

February 26, 2025 22:16

Savolro deployed to Internal

February 26, 2025 22:16

— with

GitHub Actions Active

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet