Minor performance optimization

NodeRedis · Apr 13, 2016 · 9335cc9 · 9335cc9
1 parent 8aba131
commit 9335cc9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/changelog.md b/changelog.md
@@ -5,6 +5,7 @@ Features
 -  Added support for `MIGRATE [...] KEYS key1, key2` (Redis >= v.3.0.6)
 -  Added build sanity check for unhandled commands with moveable keys
 -  Rebuild the commands with the newest unstable release
+-  Improved performance of .getKeyIndexes()
 
 Bugfix
 

diff --git a/index.js b/index.js
@@ -131,9 +131,10 @@ exports.getKeyIndexes = function (commandName, args, options) {
     }
     break;
   default:
-    keyStart = command.keyStart - 1;
-    keyStop = command.keyStop > 0 ? command.keyStop : args.length + command.keyStop + 1;
-    if (keyStart >= 0 && keyStop <= args.length && keyStop > keyStart && command.step > 0) {
+    // step has to be at least one in this case, otherwise the command does not contain a key
+    if (command.step > 0) {
+      keyStart = command.keyStart - 1;
+      keyStop = command.keyStop > 0 ? command.keyStop : args.length + command.keyStop + 1;
       for (i = keyStart; i < keyStop; i += command.step) {
         keys.push(i);
       }