Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging #91

Merged
merged 5 commits into from
Oct 23, 2020
Merged

Improve logging #91

merged 5 commits into from
Oct 23, 2020

Conversation

MakMuftic
Copy link
Member

@MakMuftic MakMuftic commented Oct 23, 2020 •
edited
Loading

Minor logging changes

PR Checklist

  • I have run linter localy
  • I have run unit and integration tests locally
  • Rebased to master branch / merged master
  • Updated CHANGELOG.md

Issues

Closes #88

@mpetrun5
Copy link
Member

Can you also add logs for when we add nodes back to active?

mpetrunic
mpetrunic previously approved these changes Oct 23, 2020
View reviewed changes
@MakMuftic
Copy link
Member Author

Can you also add logs for when we add nodes back to active?

Good catch 👍 Added

@MakMuftic MakMuftic requested a review from mpetrunic October 23, 2020 09:37
@mpetrun5 mpetrun5 merged commit 89e3deb into dev Oct 23, 2020
@MakMuftic MakMuftic deleted the mmuftic/improve-logging branch October 23, 2020 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpetrunic mpetrunic mpetrunic approved these changes

@mpetrun5 mpetrun5 Awaiting requested review from mpetrun5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MakMuftic @mpetrun5 @mpetrunic