Initial repo setup #9
Conversation
Add github setup, initial packages and sample command, reading config file and env variables, create Makefile.
There was a problem hiding this comment.
@MakMuftic @mpetrun5 I've added branch protection so this hasty merges cannot happen anymore. Pls apply same stuff to vedran-daemon before anything else
| go-version: 1.13.x | ||
|
|
||
| - name: Checkout code | ||
| uses: actions/checkout@v2 |
There was a problem hiding this comment.
|
|
||
| ## Installation | ||
| You can download already built binaries for your platform from `builds` folder or get `vedran` golang package and build it locally. Find detailed instructions below. |
There was a problem hiding this comment.
We shouldn't keep builds in git but we would have them on github release page artifacts
| ``` | ||
|
|
||
| ## Development |
There was a problem hiding this comment.
add instructions for clone, install dependencies, run, test
| Run daemon app with `go run main.go [command]`. | ||
|
|
||
| Expected name of the configuration file depends on `ENV` variable. For example, if you run a daemon app with `ENV=test go run main.go start`, expected config file name is `config-test.yaml` |
There was a problem hiding this comment.
Why do we need config-test.yaml?
Everything should be configured via cli flags
| jobs: | ||
| build: | ||
| name: Run tests | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
should be ran on all 3 os-es. We can reduce build time to only run on all 3 os-es on PR and only ubuntu on push but since it's oss, it's free anyways
closes #1