Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor whitelisting #75

Merged
merged 15 commits into from
Oct 22, 2020
Merged

Refactor whitelisting #75

merged 15 commits into from
Oct 22, 2020

Conversation

MakMuftic
Copy link
Member

Refactor whitelisting so it can be initialized in memory or by providing a file.
Remove node from active and whitelisted on penalize action

PR Checklist

  • I have run linter localy
  • I have run unit and integration tests locally
  • Rebased to master branch / merged master
  • Updated CHANGELOG.md

Changes

  • Refactor whitelisting so it can save whitelisted nodes in memory or read them from the file (node id-s separated with the new line)
  • Implement functions InitWhitelisting, IsNodeWhitelisted, RemoveNodeFromWhitelisted + unit tests
  • Refactor whitelist check inside register controller to use new functions
  • Remove node from active and whitelisted on penalize action

Issues

Closes #70
Closes #69

@MakMuftic MakMuftic self-assigned this Oct 21, 2020
This was linked to issues Oct 21, 2020
Remove node when max cooldown reached #70
Closed
Refactor whitelisting #69
Closed
mpetrunic
mpetrunic previously approved these changes Oct 21, 2020
View reviewed changes
@mpetrunic mpetrunic merged commit c932dc0 into dev Oct 22, 2020
@mpetrunic mpetrunic deleted the mmuftic/refactor-whitelisting branch October 22, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpetrun5 mpetrun5 mpetrun5 approved these changes

@mpetrunic mpetrunic Awaiting requested review from mpetrunic mpetrunic is a code owner

Assignees

@MakMuftic MakMuftic

Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove node when max cooldown reached Refactor whitelisting
3 participants
@MakMuftic @mpetrunic @mpetrun5