Ping endpoint #25
Merged
Ping endpoint #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 18, 2020 09:24
mpetrunic
requested changes
Sep 18, 2020
mpetrunic
approved these changes
Sep 19, 2020
mpetrun5
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
POST /api/v1/nodes/pingsendpoint. Body should be empty, and onlyX-Auth-Headerheader set, @mpetrun5Issues
closes #3
TODO
This is a basic implementation of the ping endpoint as it only saves the latest timestamp for the specified node. Additional logic should be implemented to check when was the last ping and record if there were any downtime, also some reoccurring job should be implemented to check if some node hasn't invoked the ping endpoint for a longer time. This was out of the scope for this PR, especially with all refactoring and addition of auth related code in this PR.