Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use payout address to map stats #136

Merged
merged 3 commits into from
Dec 2, 2020
Merged

Use payout address to map stats #136

merged 3 commits into from
Dec 2, 2020

Conversation

MakMuftic
Copy link
Member

@MakMuftic MakMuftic commented Dec 2, 2020

Replaced node ID with node payout address when mapping node stats

PR Checklist

  • I have run linter localy
  • I have run unit and integration tests locally
  • Rebased to dev branch / merged dev
  • Updated CHANGELOG.md

Changes

  • refactor stats controller + refactor unit tests
  • refactor stats collecting functions (inside /internal/stats package) so they map stats on payout addresses + refactor unit tests

Example

Here is a sample response from /api/v1/stats endpoint:

{
    "stats": {
        "5FHneW46xGXgs5mUiveU4sbTyGBzmstUspZC92UhjJM694ty": {
            "total_pings": 2630.7830677516004,
            "total_requests": 50
        }
    },
    "fee": 0.1
}

Issues

Closes #135

@MakMuftic MakMuftic marked this pull request as ready for review December 2, 2020 13:14
@mpetrun5 mpetrun5 merged commit c8eb5a9 into dev Dec 2, 2020
@mpetrunic mpetrunic deleted the mmuftic/remove-node-id branch January 8, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor stats collection to use payout address for mapping stats<->nodes
3 participants