Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.jq: 0.1.8 -> 1.0.2 #97503

Merged
merged 1 commit into from
Sep 9, 2020
Merged

python3Packages.jq: 0.1.8 -> 1.0.2 #97503

merged 1 commit into from
Sep 9, 2020

Conversation

wkral
Copy link
Contributor

@wkral wkral commented Sep 9, 2020

Motivation for this change

Noticed there was a previous attempt to update this lib, but it required a recreation of the patch which removes the attempt to downlaod and compile dependencies inside the setup.py. The source distrobution of this newer version seems to already have run cython so the included jq.c file only needs to be compiles so cython dependency was removed.

ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from benley September 9, 2020 05:36
@wkral
Copy link
Contributor Author

wkral commented Sep 9, 2020

Result of nixpkgs-review pr 97503 1

3 packages built:
  • python27Packages.jq
  • python37Packages.jq
  • python38Packages.jq

jonringer
jonringer approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 97503 1

3 packages built:
  • python27Packages.jq
  • python37Packages.jq
  • python38Packages.jq

@jonringer jonringer merged commit cf54ef9 into NixOS:master Sep 9, 2020
@wkral wkral deleted the python-jq-zhf branch September 9, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@benley benley Awaiting requested review from benley

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkral @jonringer