-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #91570 cassandra driver #91662
Fix #91570 cassandra driver #91662
Conversation
@jonringer How could the tests ever work before then? |
/marvin opt-in |
Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here. |
/status needs_review |
According to
|
2b4729f
to
ce76052
Compare
@jonringer can you have a look again? It seems like the tests could work, I just needed to update the format a bit. But I'm getting the dreaded |
To reproduce, what I do is:
|
But at the end, I get: |
Not all packages configured |
@jonringer When I do |
For reference, here is the complete log after
|
/status awaiting_changes |
Looks like the status is still unchanged here. Its usually better to ping just one, at most two people if you want advice. If you take the "shotgun" approach everybody thinks somebody else will answer for them ;) /status awaiting_changes |
Also try to summarize exactly what you want advice on when you ping someone. You might just get a glance in somebodies email inbox, they might have a busy day and decide that its not worth digging through all the PR history. Your chance for a reply is much higher if you make it as easy as possible on the person. |
What's the status of this? Might we be able to get this merged for 20.09? |
@risicle The status is that noone has reviewed the latest changes, the test suite fails, noone could propose a fix yet, and I've lost motivation to work on it if noone is reviewing or helping. I should have converted to a draft, done now. |
Reminder: Please review! This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the |
I'm looking into this among other things... |
Closed in favour of #100989 |
Motivation for this change
Fix #91570
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)