-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gen-oath-safe: add dependency on file command #88629
Conversation
@grahamc OfBorg seems stuck on "Fetching PR" - is this caused by GitHub being a bit wobbly yesterday or simply high load on OfBorg? |
ping @makefu (maintainer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@FRidh merge? |
/marvin opt-in |
Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here. |
/status needs-merger |
You have a little typo, the status is called Diff looks good to me. Would be nice if the tool had a little sanity-check test script, but at least this fixes it for now. ofBorg failure is indeed weird, lets see if we can fix it by turning it off and on again. @GrahamcOfBorg eval |
On IRC by cole-h:
Though it is weird that this PR already got stuck in May. Anyway, |
Just for testing |
Motivation for this change
file
was not listed as a dependency, causing the program to throw an error.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)