Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab: add link to nixos test in passthru.tests #63048

Merged
merged 1 commit into from
Jun 17, 2019
Merged

gitlab: add link to nixos test in passthru.tests #63048

merged 1 commit into from
Jun 17, 2019
+4 −1

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented Jun 13, 2019 •
edited
Loading

Motivation for this change

Get tooling to automatically consider the nixos test when checking the derivation looks sane. Should not change anything meaningful :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ekleog Ekleog requested a review from flokli June 13, 2019 00:28
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 13, 2019
@flokli
Copy link
Contributor

flokli commented Jun 17, 2019

LGTM. Did grok through the documentation of this attribute (thanks for that!) - while at it, can we also update the documentation there with the result of the discussion from NixOS/nix#2532?

@Ekleog
Copy link
Member Author

Ekleog commented Jun 17, 2019

Right, will do :)

@Ekleog Ekleog merged commit 42170cb into NixOS:master Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ekleog @flokli