Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.wgpu-py: init at 0.19.3 #383803

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bengsparks
Copy link

@bengsparks bengsparks commented Feb 21, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@bengsparks
Copy link
Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 383803


x86_64-linux

❌ 6 packages failed to build:
  • python312Packages.wgpu-py
  • python312Packages.wgpu-py.dist
  • python312Packages.wgpu-py.doc
  • python313Packages.wgpu-py
  • python313Packages.wgpu-py.dist
  • python313Packages.wgpu-py.doc

aarch64-linux

❌ 6 packages failed to build:
  • python312Packages.wgpu-py
  • python312Packages.wgpu-py.dist
  • python312Packages.wgpu-py.doc
  • python313Packages.wgpu-py
  • python313Packages.wgpu-py.dist
  • python313Packages.wgpu-py.doc

x86_64-darwin

✅ 6 packages built:
  • python312Packages.wgpu-py
  • python312Packages.wgpu-py.dist
  • python312Packages.wgpu-py.doc
  • python313Packages.wgpu-py
  • python313Packages.wgpu-py.dist
  • python313Packages.wgpu-py.doc

aarch64-darwin

✅ 6 packages built:
  • python312Packages.wgpu-py
  • python312Packages.wgpu-py.dist
  • python312Packages.wgpu-py.doc
  • python313Packages.wgpu-py
  • python313Packages.wgpu-py.dist
  • python313Packages.wgpu-py.doc

@bengsparks
Copy link
Author

bengsparks commented Feb 21, 2025

The failure occurs at test time, solely on linux platforms.

wgpu/utils/device.py:15: in get_default_device
adapter = wgpu.gpu.request_adapter_sync(power_preference="high-performance")
>           raise RuntimeError(error)
E           RuntimeError: Request adapter failed (1): Validation Error
E           
E           Caused by:
E             No suitable adapter found

Could someone with a real linux machine build the package successfully? Just to demonstrate if this is an emulation issue?
Upon having successfully built the package, you should be able to produce the attached image by running the wgpu-py/examples/triangle.py example.

image

I used the following dev-shell:

pkgs.mkShellNoCC {
  packages = with pkgs; [
    (python3.withPackages (
      p: [ p.wgpu-py ] ++ p.wgpu-py.optional-dependencies.glfw
    ))
  ];
}

Addendum: it appears ofborgs's passthru.tests on x86_64-darwin has failed for a similar reason, despite passing locally on my darwin system.

@bengsparks bengsparks force-pushed the wgpu-py branch 2 times, most recently from 0574f8c to a1c8730 Compare February 26, 2025 18:12
@bengsparks
Copy link
Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 383803


x86_64-linux

✅ 6 packages built:
  • python312Packages.wgpu-py
  • python312Packages.wgpu-py.dist
  • python312Packages.wgpu-py.doc
  • python313Packages.wgpu-py
  • python313Packages.wgpu-py.dist
  • python313Packages.wgpu-py.doc

aarch64-linux

✅ 6 packages built:
  • python312Packages.wgpu-py
  • python312Packages.wgpu-py.dist
  • python312Packages.wgpu-py.doc
  • python313Packages.wgpu-py
  • python313Packages.wgpu-py.dist
  • python313Packages.wgpu-py.doc

x86_64-darwin

✅ 6 packages built:
  • python312Packages.wgpu-py
  • python312Packages.wgpu-py.dist
  • python312Packages.wgpu-py.doc
  • python313Packages.wgpu-py
  • python313Packages.wgpu-py.dist
  • python313Packages.wgpu-py.doc

aarch64-darwin

✅ 6 packages built:
  • python312Packages.wgpu-py
  • python312Packages.wgpu-py.dist
  • python312Packages.wgpu-py.doc
  • python313Packages.wgpu-py
  • python313Packages.wgpu-py.dist
  • python313Packages.wgpu-py.doc

@bengsparks
Copy link
Author

bengsparks commented Feb 26, 2025

I've also built and validated the docs now.
All tests apart from version are executed exclusively on Darwin due to what I assume are sandboxing issues on Linux. I'd be very grateful if a reviewer could use the built package and run wgpu-py's examples/triangle.py example on a Linux machine, i.e. outside of a sandbox.

Their GitHub workflow references llvmpipe (i.e. mesa.llvmpipeHook) but that doesn't seem to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant