Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

element-{web,desktop}: 1.11.91 -> 1.11.94 #381196

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

transcaffeine
Copy link
Contributor

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NickCao
Copy link
Member

NickCao commented Feb 13, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 381196


x86_64-linux

❌ 1 package failed to build:
  • element-desktop
✅ 1 package built:
  • element-web (element-web-unwrapped)

@teutat3s
Copy link
Member

Waiting for https://nixpk.gs/pr-tracker.html?pr=380954 to reach the binary cache, can't build electron + element-desktop right now.

@teutat3s
Copy link
Member

teutat3s commented Feb 13, 2025

Looks like element-desktop build wants to use git for something now:

yarn install v1.22.22
[1/5] Validating package.json...
[2/5] Resolving packages...
warning Resolution field "@types/node@18.19.71" is incompatible with requested version "@types/node@^17.0.36"
error Couldn't find the binary git

EDIT: Only found something similar in #299269

@sumnerevans sumnerevans removed their request for review February 13, 2025 17:54
@transcaffeine transcaffeine force-pushed the element-web-desktop/1.11.92 branch from cd2fce9 to e85ff48 Compare February 25, 2025 18:23
@transcaffeine transcaffeine changed the title element-{web,desktop}: 1.11.91 -> 1.11.92 element-{web,desktop}: 1.11.91 -> 1.11.9{3,2} Feb 25, 2025
@transcaffeine transcaffeine marked this pull request as draft February 25, 2025 18:25
@transcaffeine
Copy link
Contributor Author

With element-desktop having updated to a node-gyp version in it's yarn.lock which resolves to a github URL, this seems to be currently blocked until fixup-yarn-lock can handle this case.
See https://raw.githubusercontent.com/element-hq/element-desktop/refs/heads/develop/yarn.lock @electron/node-gyp -> resolved

@transcaffeine transcaffeine force-pushed the element-web-desktop/1.11.92 branch from e85ff48 to 948fcf4 Compare February 27, 2025 14:56
@transcaffeine transcaffeine changed the title element-{web,desktop}: 1.11.91 -> 1.11.9{3,2} element-{web,desktop}: 1.11.91 -> 1.11.94 Feb 27, 2025
@transcaffeine transcaffeine force-pushed the element-web-desktop/1.11.92 branch from 948fcf4 to 1318f52 Compare February 27, 2025 22:11
@transcaffeine transcaffeine force-pushed the element-web-desktop/1.11.92 branch 2 times, most recently from 5fb9127 to f4eacb4 Compare February 27, 2025 22:36
@transcaffeine transcaffeine force-pushed the element-web-desktop/1.11.92 branch from f4eacb4 to 1f249a8 Compare February 27, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants