Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speechd: 0.11.5 -> 0.12.0 #375043

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

pitkling
Copy link
Member

The upgrade to 0.12.0-rc4 enables building speechd-minimal on Darwin (see the upstream changelog).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 501-1000 labels Jan 19, 2025
@nix-owners nix-owners bot requested review from jtojnar and berce January 19, 2025 12:56
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 19, 2025
@pitkling pitkling force-pushed the updates/speechd branch 2 times, most recently from b8345c5 to f78413b Compare January 19, 2025 13:41
Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the upstream diffs:

The only other significant changes I noticed are:

  • addition of PipeWire support – probably not needed for now, libpulse is still recommended for clients by PipeWire IIRC
  • addition of Open JTalk module – not currently packaged in Nixpkgs

@pitkling
Copy link
Member Author

@jtojnar Thanks for the help! I did the updates as you suggested, but cannot test them myself before tomorrow.

@pitkling pitkling force-pushed the updates/speechd branch 3 times, most recently from 6d833f1 to e9f1ca6 Compare January 21, 2025 09:37
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Jan 21, 2025
@pitkling
Copy link
Member Author

@jtojnar: I tested the socket activation on Linux, which seems to work now (I had to add the configure flag --with-systemduserunitdir=${placeholder "out"}/lib/systemd/user).

I also made the svox/pico-related postPatch conditional on withPico to avoid the svox dependency when building speechd-minimal.

@pitkling pitkling force-pushed the updates/speechd branch 3 times, most recently from 6431e64 to 0d092d6 Compare January 21, 2025 10:53
@pitkling
Copy link
Member Author

pitkling commented Feb 3, 2025

Question for someone more experienced with nixpkgs than me (@jtojnar?): Should this be rebased onto staging, given that it causes >500 rebuilds (at least on Linux; on Darwin it's much less)?

Also, is there anything else I can do to increase the chance to get this reviewed & eventually merged?

@pitkling pitkling changed the title speechd: 0.11.5 -> 0.12.0-rc4 speechd: 0.11.5 -> 0.12.0 Feb 27, 2025
@pitkling
Copy link
Member Author

Upstream recently released 0.12.0, so I updated the PR accordingly (and removed a check that's no longer needed since PR #375038 got merged). I had a quick look at the upstream diff between 0.12.0-rc4 and 0.12.0. It looks fine to me. Tested compilation again both on aarch64-darwin and x86_64-linux.

@jtojnar: Could you take another look at this? Would love to get this merged. 🙂

@pitkling pitkling requested a review from jtojnar February 27, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants