-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
speechd: 0.11.5 -> 0.12.0 #375043
base: master
Are you sure you want to change the base?
speechd: 0.11.5 -> 0.12.0 #375043
Conversation
b8345c5
to
f78413b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through the upstream diffs:
- brailcom/speechd@0.11.5...0.12.0-rc1
- brailcom/speechd@0.12.0-rc1...0.12.0-rc2
- brailcom/speechd@0.12.0-rc2...0.12.0-rc3
- brailcom/speechd@0.12.0-rc3...0.12.0-rc4
The only other significant changes I noticed are:
- addition of PipeWire support – probably not needed for now, libpulse is still recommended for clients by PipeWire IIRC
- addition of Open JTalk module – not currently packaged in Nixpkgs
@jtojnar Thanks for the help! I did the updates as you suggested, but cannot test them myself before tomorrow. |
6d833f1
to
e9f1ca6
Compare
@jtojnar: I tested the socket activation on Linux, which seems to work now (I had to add the configure flag I also made the svox/pico-related |
6431e64
to
0d092d6
Compare
Question for someone more experienced with nixpkgs than me (@jtojnar?): Should this be rebased onto staging, given that it causes >500 rebuilds (at least on Linux; on Darwin it's much less)? Also, is there anything else I can do to increase the chance to get this reviewed & eventually merged? |
The upgrade to `0.12.0` enables building `speechd-minimal` on Darwin.
2018aef
to
bd5755b
Compare
Upstream recently released 0.12.0, so I updated the PR accordingly (and removed a check that's no longer needed since PR #375038 got merged). I had a quick look at the upstream diff between 0.12.0-rc4 and 0.12.0. It looks fine to me. Tested compilation again both on @jtojnar: Could you take another look at this? Would love to get this merged. 🙂 |
The upgrade to
0.12.0-rc4
enables buildingspeechd-minimal
on Darwin (see the upstream changelog).Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.