Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

josm: 19253 -> 19277 #371299

Merged
merged 2 commits into from
Jan 6, 2025
Merged

josm: 19253 -> 19277 #371299

merged 2 commits into from
Jan 6, 2025

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Jan 6, 2025

https://josm.openstreetmap.de/wiki/Changelog/2024#a2024-12-04:Stablerelease1926524.11
There seems to be no changelog for 19277 yet.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@lucasew
Copy link
Contributor

lucasew commented Jan 6, 2025

it has source code, maybe it would be better to package it from source

https://josm.openstreetmap.de/browser/trunk

@sikmir
Copy link
Member

sikmir commented Jan 6, 2025

it has source code, maybe it would be better to package it from source

https://josm.openstreetmap.de/browser/trunk

Sure #107714, but it's not so easy.

@sikmir
Copy link
Member

sikmir commented Jan 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371299


x86_64-darwin

✅ 1 package built:
  • josm

@sikmir
Copy link
Member

sikmir commented Jan 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371299


x86_64-linux

✅ 1 package built:
  • josm

@drupol drupol merged commit 6663da5 into NixOS:master Jan 6, 2025
23 of 27 checks passed
@Luflosi Luflosi deleted the update/josm branch January 6, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants