buildLinux: add overrides for modules

[teto]

Follow up PR of #34351

• Easy override of autoModules and preferBuiltin parameters (currently living in hostSystem set).

Motivation for this change

Make it easier to configure the kernel (overriding platforms is 'hard').
One question in the previous PR was should we delete kernelAutoModules/kernelPreferBuiltin from the hostPlatform.platform.* ?
Some platforms may prefer to have builtin modules because crosscompiling is faster and having to install modules separataly would be a pain so it might make sense. Not too sure though.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Fits CONTRIBUTING.md.

---

[teto]

sry @FRidh you can ignore the request, the PR was made against staging and my rebase against master, the push triggered the request.

[teto]

@Ericson2314 @dezgeg follow up of the previous kernel patch. Seems like changing the base branch against which to evaluate the PR confused the bot.

[teto]

I moved the perl into the other set because I don't think people override it and if so it makes more sense in the callPackage call.

[teto]

@vcunat I tried to fix the useless parameters you mentioned in my previous PR. I hope it's good now.

[Ericson2314]

But do we even need to arguments like that? Just have buildLinux import instead of callPackageing generic.nix

[teto]

What's the gain of
buildLinux = makeOverridable (import ../os-specific/linux/kernel/generic.nix { inherit perl bison ... });
vs
buildLinux = makeOverridable (callPackage ../os-specific/linux/kernel/generic.nix { });
I tried to rebase but it adds other dependencies so I would like to understand why I should convert it to an import (or if you want to do it, please feel free).

[Ericson2314]

@teto having two sets of imports with a fairly arbitrary division of labor strikes me as a) confusing and b) limiting customizability by making certain inputs harder to optimize.

[teto]

I tried to merge the 2 sets as requested but then

 buildLinux = makeOverridable (import ../os-specific/linux/kernel/generic.nix {
    inherit stdenv buildPackages ncurses callPackage overrideCC gcc7 perl bison flex;
  });

triggers

$ nix-build -A linux_4_15                                                                                                                                                                                                                   
error: while evaluating 'callPackageWith' at /home/teto/nixpkgs/lib/customisation.nix:113:35, called from /home/teto/nixpkgs/pkgs/top-level/all-packages.nix:13178:16:
while evaluating 'makeOverridable' at /home/teto/nixpkgs/lib/customisation.nix:72:24, called from /home/teto/nixpkgs/lib/customisation.nix:117:8:
while evaluating anonymous function at /home/teto/nixpkgs/pkgs/os-specific/linux/kernel/linux-4.15.nix:1:1, called from /home/teto/nixpkgs/lib/customisation.nix:74:12:
while evaluating 'makeOverridable' at /home/teto/nixpkgs/lib/customisation.nix:72:24, called from /home/teto/nixpkgs/pkgs/os-specific/linux/kernel/linux-4.15.nix:5:1:
anonymous function at /home/teto/nixpkgs/pkgs/os-specific/linux/kernel/generic.nix:1:1 called without required argument 'src', at /home/teto/nixpkgs/pkgs/top-level/all-packages.nix:13444:33

and I believe we still want to make it overridable, we don't want every buildLinux call to pass all arguments, only src/patches.

NB: I also made arch overridable as I've started to use LKL, aka the Linux Kernel Library and would like eventually to have LKL use a generated config, lkl derivation is here https://github.com/teto/nixpkgs/blob/kernel_overrides/pkgs/applications/virtualization/lkl/default.nix)

[Ericson2314]

Try:

let # `let` here just for syntax highlighting

 buildLinux = attrs: callPackage ../os-specific/linux/kernel/generic.nix attrs;

[teto]

Thanks for your patience, your suggestion seems to work just fine :)

[Ericson2314]

Lmk when you think it's ready. CC @vcunat.

[teto]

I tried it on my usecase and it worked fine. I could also compile default kernels. I think it's ready if there is no further comment. I am not sure if I should split the parameters fixing and additionnal overrides in separate commit or squash everything. If the latter it can be done via github's UI.

[Ericson2314]

One big squash can be down via GitHub, but not two commits. Your call (as far as I'm concerned) which option we go with.

[teto]

@GrahamcOfBorg eval

[teto]

I made it 2 commits, both should work and can be reverted independently. They seemed to work locally not sure why grahamcofborg fails (looks master related)

[teto]

@GrahamcOfBorg eval

[grahamc]

@GrahamcOfBorg eval

[Ericson2314]

Thank you!

[Ericson2314]

Oh oops I misread; this should have gone to staging.

[vcunat]

It probably "only" rebuilds kernels (and modules), so that seems OK for master (and the count is typically close to 500 in such cases).

[Ericson2314]

whew :)