haskellPackages.system-fileio: disable checks #339341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. I’d much prefer if the explanation you gave would be in a comment (possible with a link to an issue) than in the PR description. |
|
Also please target this PR at the haskell-updates branch and make sure to mark it as draft before switching the target because it might accidentally ping a lot of people. |
flandweber
force-pushed
the
fix-haskell-system-fileio
branch
from
2bed99b to
1fafeba
Compare
This commit has been generated by maintainers/scripts/haskell/regenerate-hackage-packages.sh
flandweber
force-pushed
the
fix-haskell-system-fileio
branch
from
1fafeba to
67a00dc
Compare
Couldn't find a matching issue, but I also didn't put enough work in to be certain it doesn't exist. |
|
Yeah, fine. Let’s role with this. Thank you. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This disables tests of system-fileio as they don't typecheck after ghc 8.4.
It seems to be introduced by an api update of the unix library.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.