Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puppet-bolt: do not reset default gem config #316023

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

tie
Copy link
Member

@tie tie commented May 30, 2024

Description of changes

Add bolt overrides to the defaultGemConfig instead of not using it altogether.

Parent PR:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@tie tie requested review from anthonyroussel and uvNikita May 30, 2024 23:51
@tie tie marked this pull request as ready for review May 30, 2024 23:51
@tie tie added the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package label May 31, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 31, 2024
@anthonyroussel
Copy link
Member

anthonyroussel commented May 31, 2024

@ofborg eval

EDIT: looks like the command doesn't work :/

Copy link
Member

@anthonyroussel anthonyroussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • puppet-bolt builds and runs fine on x86_64-linux ✔️
  • dontPatchShebangs still working
  • However, ofborg eval for darwin does not pass, and looks like it is related to another package (amazonka)

@tie
Copy link
Member Author

tie commented May 31, 2024

IIRC ofborg evaluates latest PR commit, not merged branch. I’ll rebase the PR.

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Jun 1, 2024
@SuperSandro2000 SuperSandro2000 merged commit 0a4fb7a into NixOS:master Jun 2, 2024
29 checks passed
@tie tie deleted the puppet-bolt-gemconfig branch June 3, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants