Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fallout-ce: Fix broken game load/save due to case sensitive filesystem #309275

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

avnik
Copy link
Contributor

@avnik avnik commented May 5, 2024

Description of changes

Fix fallout-ce/fallout2-ce issue with save/load games if game data copied with wrong case of filenames.
(Include fix from alexbatalov/fallout1-ce#119 PR, as well as my own port of this fix for fallout2-ce)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@avnik avnik requested a review from hughobrien May 5, 2024 13:57
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 5, 2024
@hughobrien
Copy link
Contributor

I have an outstanding PR also on that repo.

alexbatalov/fallout1-ce#128

My preference is to get the upstream change merged rather than have our own quasi-fork, but it's certainly a slow process.

Let's ask for those changes to be merged and if we don't make progress we can use these patches.

@avnik
Copy link
Contributor Author

avnik commented Aug 25, 2024

@hughobrien 3 month, no reactions from upstream

@Aleksanaa Aleksanaa merged commit e74612b into NixOS:master Sep 4, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants