Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qutebrowser: cleanup #265757

Merged
merged 2 commits into from
Nov 7, 2023
Merged

qutebrowser: cleanup #265757

merged 2 commits into from
Nov 7, 2023

Conversation

dotlambda
Copy link
Member

Description of changes

Changes requested in #265364 were not made in #264965.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from a user November 6, 2023 00:43
@ofborg ofborg bot requested review from rnhmjoj, nrdxp, ebzzry and jagajaga November 6, 2023 01:21
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 6, 2023
@dotlambda dotlambda force-pushed the qutebrowser-cleanup branch 2 times, most recently from 5686e40 to cb1467d Compare November 6, 2023 01:55
@dotlambda dotlambda force-pushed the qutebrowser-cleanup branch from cb1467d to 2c6991d Compare November 6, 2023 02:56
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 6, 2023
@Artturin Artturin merged commit 8517efc into NixOS:master Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilyinstarlight lilyinstarlight lilyinstarlight left review comments

@Artturin Artturin Artturin approved these changes

@rnhmjoj rnhmjoj Awaiting requested review from rnhmjoj

@nrdxp nrdxp Awaiting requested review from nrdxp

@ebzzry ebzzry Awaiting requested review from ebzzry

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dotlambda @lilyinstarlight @Artturin @delroth