Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust-hypervisor-firmware: fix build #257345

Merged
merged 2 commits into from
Sep 26, 2023
Merged

rust-hypervisor-firmware: fix build #257345

merged 2 commits into from
Sep 26, 2023

Conversation

astro
Copy link
Contributor

@astro astro commented Sep 25, 2023 •
edited
Loading

Description of changes

Fix #256957

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@astro astro requested a review from flokli September 25, 2023 21:42
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 25, 2023
@yu-re-ka
Copy link
Contributor

@ofborg build rust-hypervisor-firmware

@yu-re-ka
Copy link
Contributor

What broke this was not the rust 1.72.0 bump, but #176694.
Some time I can go back to the drawing board and improve it, but for now this workaround is acceptable.

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 26, 2023
@astro @yuyuyureka
rust-hypervisor-firmware: add explanation
78f1398 
Co-authored-by: Yureka <yuka@yuka.dev>
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 26, 2023
@yu-re-ka yu-re-ka merged commit e97f8fe into NixOS:master Sep 26, 2023
@yu-re-ka yu-re-ka mentioned this pull request Nov 17, 2023
Merged
13 tasks
@yu-re-ka yu-re-ka mentioned this pull request Dec 17, 2023
Merged
13 tasks
alyssais added a commit to alyssais/nixpkgs that referenced this pull request Dec 17, 2023
@alyssais
Revert "rust-hypervisor-firmware: fix build (NixOS#257345)"
f0b116e 
This reverts commit e97f8fe.

No longer necessary since the rustc wrapper now handles --sysroot
correctly.
alyssais added a commit that referenced this pull request Dec 19, 2023
@alyssais
Revert "rust-hypervisor-firmware: fix build (#257345)"
1ee9f3c 
This reverts commit e97f8fe.

No longer necessary since the rustc wrapper now handles --sysroot
correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yu-re-ka yu-re-ka yu-re-ka approved these changes

@flokli flokli flokli approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure: rust-hypervisor-firmware
4 participants
@astro @yu-re-ka @flokli @delroth