Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dtc: fix cross #237100

Merged
merged 1 commit into from Jun 13, 2023
Merged

dtc: fix cross #237100

merged 1 commit into from Jun 13, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jun 10, 2023

Description of changes

Cross compilation of dtc was broken by the build system change in 280160b.

Currently dtc's configury fails for cross builds unless you disable the tests at configurePhase-time. Simply not running the test target is insufficient.

Things done
  • Built on platform(s)
    • aarch64-linux (cross from x86_64-linux)
  • Fits CONTRIBUTING.md.

Cross compilation of dtc was broken by the build system change in
280160b.

Currently dtc's configury fails for cross builds unless you disable
the tests at configurePhase-time.  Simply not running the test
target is insufficient.
@ofborg ofborg bot added 6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 10, 2023
@NickCao NickCao merged commit df55ede into NixOS:master Jun 13, 2023
@ghost ghost deleted the pr/dtc/fixcross branch June 15, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant