recoll: replace antiword with abiword #236512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 7, 2023 13:41
This commit factors out a long repetitive list of `wrapProgram` invocations into a Nix list which can be iterated upon for other purposes.
Many recoll filters assume that $PATH contains all their dependencies. Our current patching approach is a game of whack-a-mole, and while we will continue trying to play it we ought to set the $PATH as well. This commit eliminates a huge number of extraneous error messages from recoll's log, making it easier to see the remaining ones which really matter.
This cherry-picks a submitted-but-unmerged upstream patch to use abiword instead of antiword. Antiword does not understand the majority of MSWORD files, which are "quick-saved". Abiword does.
ghost
marked this pull request as draft
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This cherry-picks a submitted-but-unmerged upstream patch to use abiword instead of antiword.
Antiword does not understand the majority of MSWORD files, which are "quick-saved". Abiword does.
Includes:
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)