Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpgme: enableParallelBuilding=true #223663

Merged
merged 1 commit into from Apr 13, 2023
Merged

gpgme: enableParallelBuilding=true #223663

merged 1 commit into from Apr 13, 2023

Conversation

ghost
Copy link

@ghost ghost commented Mar 28, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ghost ghost requested a review from dotlambda March 28, 2023 23:35
dotlambda
dotlambda requested changes Mar 29, 2023
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to go to staging

@ghost ghost marked this pull request as draft April 5, 2023 08:21
@ghost ghost changed the base branch from master to staging April 5, 2023 08:22
@ghost ghost marked this pull request as ready for review April 5, 2023 08:24
@ghost ghost requested a review from dotlambda April 5, 2023 08:24
@Artturin
Copy link
Member

No failures with repeat 10 nix build ".#gpgme" --rebuild --cores 24

1m 5s -> 33s

@Artturin Artturin merged commit a288d73 into NixOS:staging Apr 13, 2023
@ghost ghost deleted the pr/gpgme/enableParallelBuilding2 branch April 13, 2023 18:43
@Artturin Artturin mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Artturin @dotlambda