nextcloud26: init at 26.0.0

[RaitoBezarius]

Description of changes

🎉
See this slide for relevant changelog: https://youtu.be/docYiLbGSxI?t=5058
https://nextcloud.com/blog/hub-4-pioneers-ethical-ai-integration-for-a-more-productive-and-collaborative-future/

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

closes #219929

[icewind1991]

the "remove custom dbuser creation" patch isn't required anymore for 26, you can now disable that behavior by setting NC_setup_create_db_user=false during setup or add "setup_create_db_user" => false to config.php before setup.

[RaitoBezarius]

the "remove custom dbuser creation" patch isn't required anymore for 26, you can now disable that behavior by setting NC_setup_create_db_user=false during setup or add "setup_create_db_user" => false to config.php before setup.

Thank you for the remark!

[RaitoBezarius]

the "remove custom dbuser creation" patch isn't required anymore for 26, you can now disable that behavior by setting NC_setup_create_db_user=false during setup or add "setup_create_db_user" => false to config.php before setup.

Done.

[RaitoBezarius]

@Ma27 do you think we should remove NC24?

[GaetanLepage]

Shouldn't it be added here as well ?

nixpkgs/nixos/modules/services/web-apps/nextcloud.nix

Line 207 in 60c1d71

relatedPackages = [ "nextcloud24" "nextcloud25" ];

[Ma27]

I'll try to take a look later today, but no guarantees because exam phase.

[Ma27]

@Ma27 do you think we should remove NC24?

Let's await the final patch release. Reason is quite simple: we can automatically backport all updates on the next updates and we don't have to fix up the backport.

Btw, I'd resolve the review comments and drop the nextcloud23 references (this makes the module simpler on some occasions) and deploy the changes to my setup. Would it be OK if I push the changes after that to your branch? :)

[RaitoBezarius]

@Ma27 do you think we should remove NC24?

Let's await the final patch release. Reason is quite simple: we can automatically backport all updates on the next updates and we don't have to fix up the backport.

Got it.

Btw, I'd resolve the review comments and drop the nextcloud23 references (this makes the module simpler on some occasions) and deploy the changes to my setup. Would it be OK if I push the changes after that to your branch? :)

Please do so! It's running on my setup since the opening of this PR, no trouble so far.

[Ma27]

@RaitoBezarius btw, why does 881efdb state that the stateVersion logic is broken? The change seems OK to me :)

[Ma27]

FWIW I got bitten by nextcloud/user_saml#709, but considering that we don't ship SAML by default and the workaround is trivial I don't consider this a blocker.

[Ma27]

LGTM. @RaitoBezarius would merge soonish if that's OK :)

[Ma27]

Also needs a manual backport (i.e. backport pf pkgs.nextcloud26), but without the breaking stuff (i.e. changed defaults). Happy to take care of that soonisherer (what's it called if it's soon, but after the soonish from the latest comment? 🤔 )

[RaitoBezarius]

LGTM. @RaitoBezarius would merge soonish if that's OK :)

Completely fine to merge it once CI is green. :)

[RaitoBezarius]

@RaitoBezarius btw, why does 881efdb state that the stateVersion logic is broken? The change seems OK to me :)

Fixed, excessive amount of carefulness. :)