Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpgme: update patch to support Python 3.11 #216235

Merged
merged 1 commit into from
Feb 16, 2023
Merged

gpgme: update patch to support Python 3.11 #216235

merged 1 commit into from
Feb 16, 2023

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Feb 13, 2023

Description of changes

Fix build (https://hydra.nixos.org/build/207440058)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@fabaff fabaff mentioned this pull request Feb 13, 2023
Merged
12 tasks
@hesiod
Copy link
Contributor

hesiod commented Feb 13, 2023

I think this might have to go into staging. 656 affected packages.

@fabaff fabaff marked this pull request as draft February 16, 2023 11:10
@fabaff fabaff changed the base branch from master to staging February 16, 2023 11:15
@fabaff fabaff marked this pull request as ready for review February 16, 2023 11:15
@fabaff
Copy link
Member Author

fabaff commented Feb 16, 2023

@ofborg build gpgme python310Packages.scmrepo python311Packages.scmrepo

davidak
davidak approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good

ofborg checks successful

@fabaff fabaff merged commit 10abbea into NixOS:staging Feb 16, 2023
@fabaff fabaff deleted the gpgme-py311 branch February 16, 2023 23:12
@fabaff fabaff mentioned this pull request Feb 22, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak davidak approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabaff @hesiod @davidak