Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python2: fix eval #216189

Merged
merged 1 commit into from
Feb 13, 2023
Merged

python2: fix eval #216189

merged 1 commit into from
Feb 13, 2023

Conversation

alyssais
Copy link
Member

Description of changes

Fixes: ee90eca ("cpython: Migrate sha256 occurences to hash")

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@alyssais
python2: fix eval
b4f74e3 
Fixes: ee90eca ("cpython: Migrate sha256 occurences to hash")
@alyssais alyssais requested a review from mweinelt February 13, 2023 17:15
@alyssais alyssais requested a review from FRidh as a code owner February 13, 2023 17:15
@alyssais alyssais mentioned this pull request Feb 13, 2023
Merged
13 tasks
@mweinelt mweinelt merged commit d56a97c into NixOS:staging Feb 13, 2023
@alyssais alyssais deleted the python2-eval branch February 13, 2023 17:20
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Feb 13, 2023
@ofborg ofborg bot requested a review from thiagokokada February 13, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt Awaiting requested review from mweinelt

@FRidh FRidh Awaiting requested review from FRidh

@thiagokokada thiagokokada Awaiting requested review from thiagokokada

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alyssais @mweinelt