Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raft-canonical: 0.16.0 -> 0.17.1 #213406

Merged
merged 4 commits into from
Feb 1, 2023

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/canonical/raft/releases.

meta.description for raft-canonical is: Fully asynchronous C implementation of the Raft consensus protocol

meta.homepage for raft-canonical is: https://github.com/canonical/raft

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 0.17.1 with grep in /nix/store/yh6j2837igm58j4hbsmq7k8as6x4dfxc-raft-canonical-0.17.1-dev
  • found 0.17.1 in filename of file in /nix/store/yh6j2837igm58j4hbsmq7k8as6x4dfxc-raft-canonical-0.17.1-dev

Rebuild report (if merged into master) (click to expand)
3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath
dqlite
lxd
raft-canonical
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/yh6j2837igm58j4hbsmq7k8as6x4dfxc-raft-canonical-0.17.1-dev \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A raft-canonical https://github.com/r-ryantm/nixpkgs/archive/b24f64bef4c8cc814316f711fbb7f66477574c34.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/yh6j2837igm58j4hbsmq7k8as6x4dfxc-raft-canonical-0.17.1-dev
ls -la /nix/store/yh6j2837igm58j4hbsmq7k8as6x4dfxc-raft-canonical-0.17.1-dev/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:
  • lxd
2 packages built:
  • dqlite
  • raft-canonical

Maintainer pings

cc @wucke13 @adamcstephens for testing.

@ofborg ofborg bot requested review from wucke13 and adamcstephens January 29, 2023 17:43
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 29, 2023
@marsam
Copy link
Contributor

marsam commented Jan 29, 2023

@GrahamcOfBorg test lxd

@ofborg ofborg bot requested a review from jokogr January 29, 2023 19:19
@adamcstephens
Copy link
Contributor

adamcstephens commented Jan 29, 2023

lxd 5.10/5.0.2 were released before raft-canonical 0.17.1, so there is not yet an lxd release using this. This came out while I was working on upgrading raft 0.16.0 but I opted to skip it for that reason (and it was enough work troubleshooting the tests on 0.16.0).

We may want to wait for lxd 5.11 because of this as it looks like this is failing to build lxd 5.10 anyway.

@wegank wegank marked this pull request as draft January 30, 2023 04:09
@marsam
Copy link
Contributor

marsam commented Jan 30, 2023

I think is safe to merge it, lxd builds and the tests pass.
The only breaking change is raft_uv_init which is addressed by dqlite 1.14.0.

@marsam marsam marked this pull request as ready for review February 1, 2023 00:49
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 213406 run on x86_64-linux 1

3 packages built:
  • dqlite
  • lxd
  • raft-canonical

@NickCao NickCao merged commit 585af06 into NixOS:master Feb 1, 2023
@r-ryantm r-ryantm deleted the auto-update/raft-canonical branch February 1, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants