mips64: bootstrap-files #161927
Closed
mips64: bootstrap-files #161927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 21, 2022 02:21
MIPS has an uncharacteristically-large space of permutations for
{architecture,abi,endianness}; this patch adds all of them to
lib/systems/platforms.nix so we can be done with it.
Currently lib/systems/inspect.nix has a single "isMips" predicate,
which is a bit ambiguous now that we will have both mips32 and mips64
support, with the latter having two ABIs. Let's add four new
predicates (isMips32, isMips64, isMips64n32, and isMips64n64) and
treat the now-ambiguous isMips as deprecated in favor of the
more-specific predicates. These predicates are used mainly for
enabling/disabling target-specific workarounds, and it is extremely
rare that a platform-specific workaround is needed, and both mips32
and mips64 need exactly the same workaround.
The separate predicates (isMips64n32 and isMips64n64) for ABI
distinctions are, unfortunately, useful. Boost's user-scheduled
threading (used by nix) does does not currently supports mips64n32,
which is a very desirable ABI on routers since they rarely have
more than 2**32 bytes of DRAM.
This corrects a mistake made when transcribing the ABI coordinate of the first two tuples from https://wiki.debian.org/Multiarch/Tuples
The predicate for isMips64n32 matches not only mips64el-*-gnuabin32, but also mips64el-*-muslabin32. This is the desired/expected behavior. However the definition of isMips64n32 mentions abis.gnuabin32, which might mislead a reader into believing that the predicate matches only glibc targets. This commit inlines the definition of abis.gnuabin32, leaving the predicate's behavior unchanged while avoiding potential confusion. Likewise for isMips64n64.
This is used in the bootstrap process, which involves cross-compiling a statically-linked nix binary.
ghost
requested review from
nbp,
Ericson2314,
matthewbauer,
alyssais,
edolstra and
infinisil
as code owners
ghost
marked this pull request as draft
github-actions
bot
added
6.topic: stdenv
ofborg
bot
added
10.rebuild-darwin: 0
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the bootstrap-files.tar.xz can be generated without this PR, and the remainder of this PR should wait until the Hydra-generated hash values for bootstrap-files.tar.xz are available, so I am closing this PR.
This PR is currently marked as "draft" while I check that everything still bootstraps properly.Motivation for this change
To be able to use nixpkgs on mips64el. I intend to set up a Hydra instance. Western Semiconductor has offered to donate hardware (and hosting if desired).
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes