Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21.05] graylog: 3.3.9 -> 3.3.15 #150904

Merged
merged 2 commits into from
Dec 18, 2021
Merged

[21.05] graylog: 3.3.9 -> 3.3.15 #150904

merged 2 commits into from
Dec 18, 2021

Conversation

0x4A6F
Copy link
Member

@0x4A6F 0x4A6F commented Dec 15, 2021

Motivation for this change

Backport of #150511.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@0x4A6F 0x4A6F requested review from LeSuisse and fadenb December 15, 2021 22:29
@0x4A6F 0x4A6F added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Dec 15, 2021
LeSuisse
LeSuisse requested changes Dec 16, 2021
View reviewed changes
Copy link
Member

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this work, the commit is not formatted according to the contributing guidelines.

We should probably cherry pick c82cc16 and 6dd67c3 instead of modifying the last one.

@0x4A6F 0x4A6F force-pushed the backport-150511-to-release-21.05 branch from bab5454 to 0f0982c Compare December 16, 2021 13:47
@0x4A6F 0x4A6F requested a review from LeSuisse December 16, 2021 14:20
@0x4A6F 0x4A6F mentioned this pull request Dec 18, 2021
Closed
@0x4A6F 0x4A6F changed the title [21.05] graylog: 3.3.14 -> 3.3.15 [21.05] graylog: 3.3.9 -> 3.3.15 Dec 18, 2021
mweinelt
mweinelt approved these changes Dec 18, 2021
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on x86_64-linux.

@mweinelt mweinelt merged commit 564f81d into NixOS:release-21.05 Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@LeSuisse LeSuisse LeSuisse approved these changes

@fadenb fadenb Awaiting requested review from fadenb

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0x4A6F @mweinelt @LeSuisse @fadenb