Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle: 7.3.1 -> 7.3.2 #150866

Merged
merged 1 commit into from
Dec 15, 2021
Merged

gradle: 7.3.1 -> 7.3.2 #150866

merged 1 commit into from
Dec 15, 2021

Conversation

lorenzleutgeb
Copy link
Member

@lorenzleutgeb lorenzleutgeb commented Dec 15, 2021

@lorenzleutgeb
Copy link
Member Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2 label Dec 15, 2021
@marvin-mk2
Copy link

marvin-mk2 bot commented Dec 15, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added needs_reviewer (old Marvin label, do not use) awaiting_reviewer (old Marvin label, do not use) and removed needs_reviewer (old Marvin label, do not use) labels Dec 15, 2021
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Dec 15, 2021
@kevincox
Copy link
Contributor

Result of nixpkgs-review pr 150866 run on x86_64-linux 1

1 package marked as broken and skipped:
  • impressive
6 packages failed to build:
  • apkleaks
  • diffoscope
  • gscan2pdf
  • jadx
  • pdfchain
  • pdftk
3 packages built:
  • gradle (gradle_7)
  • kotlin-language-server
  • scenic-view

@kevincox
Copy link
Contributor

Those were all already broken.

@kevincox kevincox merged commit 2ec48cd into NixOS:master Dec 15, 2021
@trofi
Copy link
Contributor

trofi commented Dec 17, 2021

Bisect says gradle: 7.3.1 -> 7.3.2 5fed9ba broke pdftk on master (a diffoscope dependency):

$ nix build -f. pdftk -L
...
pdftk> FAILURE: Build failed with an exception.
pdftk> * What went wrong:
pdftk> A problem occurred configuring root project 'pdftk'.
pdftk> > Could not resolve all files for configuration ':classpath'.
pdftk>    > Could not find org.apache.logging.log4j:log4j-core:2.16.0.
pdftk>      Searched in the following locations:
...

https://hydra.nixos.org/log/1bpzawlbqs0jv09axavb8zg1ym74b3ig-pdftk-3.2.1.drv

@lorenzleutgeb
Copy link
Member Author

Starting point to fix pdftk is:

A problem occurred configuring root project 'pdftk'.
> Could not resolve all files for configuration ':classpath'.
   > Could not find org.apache.logging.log4j:log4j-core:2.16.0.
     Searched in the following locations:
       - file:/nix/store/q8bqws0qadicb1w14vhf2c2rigknw8l8-pdftk-deps-3.2.1/org/apache/logging/log4j/log4j-core/2.16.0/log4j-core-2.16.0.pom
     If the artifact you are trying to retrieve can be found in the repository but without metadata in 'Maven POM' format, you need to adjust the 'metadataSources { ... }' of the repository declaration.
     Required by:
         project :
   > Could not find org.apache.logging.log4j:log4j-core:2.16.0.
     Searched in the following locations:
       - file:/nix/store/q8bqws0qadicb1w14vhf2c2rigknw8l8-pdftk-deps-3.2.1/org/apache/logging/log4j/log4j-core/2.16.0/log4j-core-2.16.0.pom
     If the artifact you are trying to retrieve can be found in the repository but without metadata in 'Maven POM' format, you need to adjust the 'metadataSources { ... }' of the repository declaration.
     Required by:
         project : > com.github.johnrengelman.shadow:com.github.johnrengelman.shadow.gradle.plugin:5.2.0 > com.github.jengelman.gradle.plugins:shadow:5.2.0

I can work on this tomorrow afternoon CET. If that's too late, consider reverting.

@lorenzleutgeb
Copy link
Member Author

lorenzleutgeb commented Dec 17, 2021

Got a PR accepted upstream, see https://gitlab.com/pdftk-java/pdftk/-/merge_requests/25 which is related. But TBH I don't think it will fix the build failure above. Will investigate tomorrow.

@lorenzleutgeb lorenzleutgeb mentioned this pull request Dec 18, 2021
13 tasks
@lorenzleutgeb
Copy link
Member Author

lorenzleutgeb commented Dec 18, 2021

@trofi see #151188, which got merged. Please verify and report back if you have trouble building diffoscope. It builds fine for me on e1f9e75. Sorry for the inconvenience caused.

@trofi
Copy link
Contributor

trofi commented Dec 18, 2021

diffoscope builds successfully on master now. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes awaiting_reviewer (old Marvin label, do not use) marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants