Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/jitsi-meet: Mitigate CVE-2021-44228 #150021

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

yayayayaka
Copy link
Member

Motivation for this change

This commit mitigates a remote code execution vulnerability in the log4j
library.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 10, 2021
@yayayayaka yayayayaka added 1.severity: security Issues which raise a security issue, or PRs that fix one backport release-21.11 labels Dec 10, 2021
@yayayayaka yayayayaka requested a review from yu-re-ka December 10, 2021 09:43
@yu-re-ka
Copy link
Contributor

More information on the vulnerability: https://www.lunasec.io/docs/blog/log4j-zero-day/

@yu-re-ka
Copy link
Contributor

Strictly the commit message(s) should be nixos/jitsi-videobridge: ..., nixos/jicofo: ... and so on, because this changes the module not the package

@yayayayaka
Copy link
Member Author

Alright.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 10, 2021
@yayayayaka yayayayaka force-pushed the jitsi-fix-CVE-2021-44228 branch from 0fab575 to 39cbc2b Compare December 10, 2021 09:58
This commit mitigates a remote code execution vulnerability in the log4j
library.
@yayayayaka yayayayaka force-pushed the jitsi-fix-CVE-2021-44228 branch from 39cbc2b to ea418c4 Compare December 10, 2021 10:00
@yu-re-ka
Copy link
Contributor

I'm not sure if jibri and jicofo actually use Log4j, but better safe than sorry

@yu-re-ka yu-re-ka requested review from rycee, cleeyv and mmilata December 10, 2021 10:01
@yayayayaka yayayayaka changed the title jitsi-meet: Mitigate CVE-2021-44228 nixos/jitsi-meet: Mitigate CVE-2021-44228 Dec 10, 2021
@KamilaBorowska
Copy link
Member

KamilaBorowska commented Dec 10, 2021

Actually, good point, I don't think jibri and jicofo actually use Log4j, checked the JARs involved, no trace of Log4j.

@KamilaBorowska KamilaBorowska self-requested a review December 10, 2021 10:06
@KamilaBorowska
Copy link
Member

jitsi-videobridge2 uses Log4j, Jibri and Jicofo don't. I think it would make sense to restrict the change to jitsi-videobridge2 only.

Copy link
Member

@KamilaBorowska KamilaBorowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think commits other than "nixos/jitsi-videobridge: Mitigate CVE-2021-44228" can be removed, as those programs don't use Log4J, and as such are unaffected by the vulnerability.

@yayayayaka yayayayaka force-pushed the jitsi-fix-CVE-2021-44228 branch from ea418c4 to 4925948 Compare December 10, 2021 10:16
@yu-re-ka yu-re-ka merged commit c2b7987 into NixOS:master Dec 10, 2021
@yayayayaka
Copy link
Member Author

Thanks @xfix for your review. I have removed the other commits.

@yayayayaka yayayayaka deleted the jitsi-fix-CVE-2021-44228 branch December 10, 2021 10:17
@github-actions
Copy link
Contributor

Successfully created backport PR #150027 for release-21.11.

@dotlambda
Copy link
Member

Shouldn't this also be backported to 21.05?

@ius
Copy link
Contributor

ius commented Dec 11, 2021

Shouldn't this also be backported to 21.05?

According to upstream:

Jitsi-videobridge instances older than 2.1-504 (May 2021) with callstats enabled should be updated to 2.1-504 or newer.

Which doesn't affect any of NixOS' supported channels. Accordingly this mitigation doesn't seem necessary after all.

(Additional info)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants