-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/jitsi-meet: Mitigate CVE-2021-44228 #150021
Conversation
More information on the vulnerability: https://www.lunasec.io/docs/blog/log4j-zero-day/ |
Strictly the commit message(s) should be |
Alright. |
0fab575
to
39cbc2b
Compare
This commit mitigates a remote code execution vulnerability in the log4j library.
39cbc2b
to
ea418c4
Compare
I'm not sure if jibri and jicofo actually use Log4j, but better safe than sorry |
Actually, good point, I don't think jibri and jicofo actually use Log4j, checked the JARs involved, no trace of Log4j. |
jitsi-videobridge2 uses Log4j, Jibri and Jicofo don't. I think it would make sense to restrict the change to jitsi-videobridge2 only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think commits other than "nixos/jitsi-videobridge: Mitigate CVE-2021-44228" can be removed, as those programs don't use Log4J, and as such are unaffected by the vulnerability.
ea418c4
to
4925948
Compare
Thanks @xfix for your review. I have removed the other commits. |
Successfully created backport PR #150027 for |
Shouldn't this also be backported to 21.05? |
According to upstream:
Which doesn't affect any of NixOS' supported channels. Accordingly this mitigation doesn't seem necessary after all. |
Motivation for this change
This commit mitigates a remote code execution vulnerability in the log4j
library.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes