Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python39Packages.cliff: fix missing dependency, tests and adopt to openstack team #137557

Merged
merged 2 commits into from
Sep 14, 2021
Merged

python39Packages.cliff: fix missing dependency, tests and adopt to openstack team #137557

merged 2 commits into from
Sep 14, 2021

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member Author

@ofborg eval

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Sep 12, 2021
@ofborg ofborg bot requested review from emilytrau and superherointj September 12, 2021 20:17
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Sep 12, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented Sep 12, 2021 •
edited
Loading

Result of nixpkgs-review pr 137557 at 6bb1eb1c run on aarch64-linux 1

6 packages failed to build:
2 packages skipped due to time constraints:
  • python38Packages.optuna
  • python39Packages.optuna
34 packages built successfully:
  • python38Packages.autopage
  • python38Packages.cliff
  • python38Packages.hacking
  • python38Packages.keystoneauth1
  • python38Packages.oslo-concurrency
  • python38Packages.oslo-config
  • python38Packages.oslo-context
  • python38Packages.oslo-db
  • python38Packages.oslo-i18n
  • python38Packages.oslo-log
  • python38Packages.oslo-serialization
  • python38Packages.oslo-utils
  • python38Packages.python-cinderclient
  • python38Packages.python-keystoneclient
  • python38Packages.python-novaclient
  • python38Packages.stestr
  • python38Packages.subunit2sql
  • python39Packages.autopage
  • python39Packages.cliff
  • python39Packages.hacking
  • python39Packages.keystoneauth1
  • python39Packages.oslo-concurrency
  • python39Packages.oslo-config
  • python39Packages.oslo-context
  • python39Packages.oslo-db
  • python39Packages.oslo-i18n
  • python39Packages.oslo-log
  • python39Packages.oslo-serialization
  • python39Packages.oslo-utils
  • python39Packages.python-cinderclient
  • python39Packages.python-keystoneclient
  • python39Packages.python-novaclient
  • python39Packages.stestr
  • python39Packages.subunit2sql
1 suggestion:
  • warning: python-include-tests

    Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

    Near pkgs/development/python-modules/cliff/default.nix:47:0:

       |
47 |     description = "Command Line Interface Formulation Framework";
   | ^

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

Result of nixpkgs-review pr 137557 at 6bb1eb1c run on x86_64-linux 1

6 packages failed to build:
2 packages skipped due to time constraints:
  • python38Packages.optuna
  • python39Packages.optuna
34 packages built successfully:
  • python38Packages.autopage
  • python38Packages.cliff
  • python38Packages.hacking
  • python38Packages.keystoneauth1
  • python38Packages.oslo-concurrency
  • python38Packages.oslo-config
  • python38Packages.oslo-context
  • python38Packages.oslo-db
  • python38Packages.oslo-i18n
  • python38Packages.oslo-log
  • python38Packages.oslo-serialization
  • python38Packages.oslo-utils
  • python38Packages.python-cinderclient
  • python38Packages.python-keystoneclient
  • python38Packages.python-novaclient
  • python38Packages.stestr
  • python38Packages.subunit2sql
  • python39Packages.autopage
  • python39Packages.cliff
  • python39Packages.hacking
  • python39Packages.keystoneauth1
  • python39Packages.oslo-concurrency
  • python39Packages.oslo-config
  • python39Packages.oslo-context
  • python39Packages.oslo-db
  • python39Packages.oslo-i18n
  • python39Packages.oslo-log
  • python39Packages.oslo-serialization
  • python39Packages.oslo-utils
  • python39Packages.python-cinderclient
  • python39Packages.python-keystoneclient
  • python39Packages.python-novaclient
  • python39Packages.stestr
  • python39Packages.subunit2sql
1 suggestion:
  • warning: python-include-tests

    Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

    Near pkgs/development/python-modules/cliff/default.nix:47:0:

       |
47 |     description = "Command Line Interface Formulation Framework";
   | ^

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

@superherointj superherointj mentioned this pull request Sep 13, 2021
Merged
12 tasks
@ofborg ofborg bot requested a review from superherointj September 14, 2021 12:10
@SuperSandro2000 SuperSandro2000 merged commit 0c17ce6 into NixOS:staging-next Sep 14, 2021
@SuperSandro2000 SuperSandro2000 deleted the cliff branch September 14, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@emilytrau emilytrau Awaiting requested review from emilytrau

@superherointj superherointj Awaiting requested review from superherointj

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SuperSandro2000 @r-rmcgibbo @superherointj