pythonPackages.py-multihash: 0.2.3 -> 1.0.0 #101801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Build on darwin:
Result of nixpkgs-review pr 101801 1
2 packages built:
- python37Packages.py-multihash
- python38Packages.py-multihash
mweinelt
requested changes
Oct 28, 2020
IvarWithoutBones
force-pushed
the
fix-multihash
branch
2 times, most recently
from
3d14b67 to
0a05a32
Compare
IvarWithoutBones
force-pushed
the
fix-multihash
branch
from
0a05a32 to
dd7b6a5
Compare
IvarWithoutBones
changed the title
|
Result of 2 packages built:
|
mweinelt
approved these changes
Nov 11, 2020
10 tasks
Luflosi
added a commit
to Luflosi/nixpkgs
that referenced
this pull request
Feb 8, 2021
This was marked broken in NixOS#101636, which was merged into the staging branch. Later, the package was updated and fixed in NixOS#101801. When the staging branch was then merged into master, the package was marked as broken while actually being fixed.
This was referenced Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Saw this failing on hydra, and decided to fix it.
the
postPatchphase should be removed upon the next release, as explained in the comment.ZHF: #97479
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)