Skip to content

Commit

Permalink
separateDebugInfo: use NIX_RUSTFLAGS
Browse files Browse the repository at this point in the history
Setting RUSTFLAGS causes Cargo to ignore other ways of configuring
flags, including the target-specific RUSTFLAGS options.  This broke
pkgsCross.musl64.crosvm, and was surprising to users.

Fixes: #261727
  • Loading branch information
alyssais committed Nov 17, 2023
1 parent e8251fa commit 47c1fa2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkgs/build-support/setup-hooks/separate-debug-info.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
export NIX_SET_BUILD_ID=1
export NIX_LDFLAGS+=" --compress-debug-sections=zlib"
export NIX_CFLAGS_COMPILE+=" -ggdb -Wa,--compress-debug-sections"
export RUSTFLAGS+=" -g"
export NIX_RUSTFLAGS+=" -g"

fixupOutputHooks+=(_separateDebugInfo)

Expand Down

0 comments on commit 47c1fa2

Please sign in to comment.