Give Derivation::tryResolve an evalStore argument
#9563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
store
thufschmitt
suggested changes
Dec 8, 2023
There was a problem hiding this comment.
I think the change is good overall (and needed by Hydra indeed).
I'm more reserved regarding 194ae13 which seems like a net-negative to me
Ericson2314
changed the title
Derivation::tryResolve an evalStore argument, and other improvementsDerivation::tryResolve an evalStore argument
This is needed for building CA deriations with a src store / dest store split. In particular it is needed for Hydra. NixOS/hydra#838 currently puts realizations, and thus build outputs, in the local store, but it should not.
Ericson2314
force-pushed
the
tryResolve-evalStore
branch
from
9b64f7d to
96dd757
Compare
Dropped it for now! |
thufschmitt
approved these changes
Dec 8, 2023
Ericson2314
added
the
backport 2.19-maintenance
|
Successfully created backport PR for |
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Dec 10, 2023
Picking up where NixOS#9563 left off.
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Dec 11, 2023
Picking up where NixOS#9563 left off.
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Dec 11, 2023
Picking up where NixOS#9563 left off. (cherry picked from commit ba5349c)
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Dec 11, 2023
Picking up where NixOS#9563 left off.
tebowy
pushed a commit
to tebowy/nix
that referenced
this pull request
Jul 11, 2024
Give `Derivation::tryResolve` an `evalStore` argument (cherry picked from commit 36ca6ad) Change-Id: If76b185a01ffa982e4c49cf333a9b5fbf9edebfe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is needed for building CA deriations with a src store / dest store split. In particular it is needed for Hydra.
Context
NixOS/hydra#838 currently puts realizations, and thus build outputs, in the local store, but it should not.
Priorities
Add 👍 to pull requests you find important.