Bare minimum ssh-ng:// extensions for Hydra
#12479
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not as comprehensive as #10748, but I am also interested in figuring out whether all those additions are in fact necessary. This is bare minimum needed for NixOS/hydra#1445, which has notable gaps but nevertheless reimplements enough with `ssh-ng://` to past all tests. I would like to merge this change as definitely necessary, and unclear whether sufficient. Then I would iterate on the corresponding Hydra PR until it seems potentially correct, seeing what, if any, further Nix API changes are necessary.
github-actions
bot
added
the
store
Mic92
reviewed
Feb 18, 2025
| @@ -122,6 +122,16 @@ public: | |||
| BuildResult buildDerivation(const StorePath & drvPath, const BasicDerivation & drv, | |||
| BuildMode buildMode) override; | |||
|
|
|||
| /** | |||
| * Note, the returned function must only be called once, or we'll | |||
| * try to read from the connection twice. | |||
There was a problem hiding this comment.
Suggested change
| * try to read from the connection twice. | |
| * try to read from the connection twice. | |
| * This function is used by Hydra. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is not as comprehensive as #10748, but I am also interested in figuring out whether all those additions are in fact necessary.
This is bare minimum needed for
NixOS/hydra#1445, which has notable gaps but nevertheless reimplements enough with
ssh-ng://to past all tests.I would like to merge this change as definitely necessary, and unclear whether sufficient. Then I would iterate on the corresponding Hydra PR until it seems potentially correct, seeing what, if any, further Nix API changes are necessary.
Context
NixOS/hydra#1445, NixOS/hydra#688 and #4665
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.