Support different types of bytes input #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
==========================================
- Coverage 79.54% 79.54% -0.01%
==========================================
Files 751 751
Lines 13255 13258 +3
==========================================
+ Hits 10544 10546 +2
- Misses 2711 2712 +1 ☔ View full report in Codecov by Sentry. |
q-nk
reviewed
Nov 17, 2023
Previously, we required bytes input as a BufferedReader. With this patch, we also accept FileIO and bytes instances, as supported by the generated API client. Fixes: #63
robin-nitrokey
force-pushed
the
bytes-input
branch
from
d32fd0f to
0b1e288
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we required bytes input as a BufferedReader. With this patch, we also accept FileIO and bytes instances, as supported by the generated API client.
Fixes: #63